[PR #6983] [MERGED] fix: launch review issues 0.7.8 #7671

Closed
opened 2026-03-23 23:20:41 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6983
Author: @richardshiue
Created: 12/13/2024
Status: Merged
Merged: 12/13/2024
Merged by: @richardshiue

Base: mainHead: fix/launch-review-0.7.8


📝 Commits (5)

  • 9fe7e92 chore: mention popup height match design
  • fba6f52 chore: adding while scrolling through mention page popup
  • 4dc3fb2 chore: don't add @ and restart creating mention when already in the middle of one
  • 24cc794 fix: hide orphan views from mention page
  • b667904 fix: arrow navigation wrap mention page popup breaks bloc

📊 Changes

7 files changed (+41 additions, -37 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/ai_chat/application/chat_input_control_cubit.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/chat_mention_page_bottom_sheet.dart (+1 -4)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/chat_mention_page_menu.dart (+7 -8)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/desktop_ai_prompt_input.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/mobile_ai_prompt_input.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/view_title/view_title_bar_bloc.dart (+23 -19)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart (+1 -2)

📄 Description

  • mention popup height match design
  • adding while scrolling through mention page popup
  • don't add @ and restart creating mention when already in the middle of one
  • hide orphan views from mention page
  • arrow navigation wrap mention page popup breaks bloc

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6983 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/13/2024 **Status:** ✅ Merged **Merged:** 12/13/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/launch-review-0.7.8` --- ### 📝 Commits (5) - [`9fe7e92`](https://github.com/AppFlowy-IO/AppFlowy/commit/9fe7e92d40ce2c96403f4e8510f33eff087d1d30) chore: mention popup height match design - [`fba6f52`](https://github.com/AppFlowy-IO/AppFlowy/commit/fba6f520d5b7df6850076958ae9b67b35d7ba659) chore: adding while scrolling through mention page popup - [`4dc3fb2`](https://github.com/AppFlowy-IO/AppFlowy/commit/4dc3fb2d39668c1def31f862327f6a07cdbf7f9c) chore: don't add @ and restart creating mention when already in the middle of one - [`24cc794`](https://github.com/AppFlowy-IO/AppFlowy/commit/24cc7943eb1dfb605e0a7691b83a476da6547ed7) fix: hide orphan views from mention page - [`b667904`](https://github.com/AppFlowy-IO/AppFlowy/commit/b667904eab5547c8b970ad444251fb87b1f61826) fix: arrow navigation wrap mention page popup breaks bloc ### 📊 Changes **7 files changed** (+41 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/application/chat_input_control_cubit.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/chat_mention_page_bottom_sheet.dart` (+1 -4) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/chat_mention_page_menu.dart` (+7 -8) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/desktop_ai_prompt_input.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_input/mobile_ai_prompt_input.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/view_title/view_title_bar_bloc.dart` (+23 -19) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart` (+1 -2) </details> ### 📄 Description - mention popup height match design - adding while scrolling through mention page popup - don't add @ and restart creating mention when already in the middle of one - hide orphan views from mention page - arrow navigation wrap mention page popup breaks bloc ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:41 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7671
No description provided.