[PR #7048] [MERGED] feat: support plus menu in table cell on mobile #7704

Closed
opened 2026-03-23 23:20:50 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7048
Author: @LucasXu0
Created: 12/26/2024
Status: Merged
Merged: 12/26/2024
Merged by: @LucasXu0

Base: mainHead: feat/plus_menu_on_mobile


📝 Commits (4)

  • 9a002db feat: support plus menu in table cell on mobile
  • ec1c5a5 test: support plus menu in table cell on mobile
  • afb355a feat: add lightImpact feedback
  • 55d10d6 chore: optimize the action sheet

📊 Changes

9 files changed (+578 additions, -334 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/mobile/document/simple_table_test.dart (+51 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart (+14 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_block_component.dart (+9 -2)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/add_block_menu_item_builder.dart (+480 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/add_block_toolbar_item.dart (+7 -324)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_cell_block_component.dart (+11 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_action_sheet.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_feedback.dart (+1 -0)

📄 Description

Feature Preview

  • support showing add block menu in table cell on mobile
    • exclude the database
    • exclude the photo gallery
    • exclude the table
  • test
Screenshot 2024-12-26 at 09 10 07 1

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7048 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 12/26/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/plus_menu_on_mobile` --- ### 📝 Commits (4) - [`9a002db`](https://github.com/AppFlowy-IO/AppFlowy/commit/9a002db6540129643aeb454b45379f25c9fa0e5f) feat: support plus menu in table cell on mobile - [`ec1c5a5`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec1c5a591d24ce32eee88fc1b5b9122d76524f0a) test: support plus menu in table cell on mobile - [`afb355a`](https://github.com/AppFlowy-IO/AppFlowy/commit/afb355abd2916ca48ce30ef30dc66e729362d7a8) feat: add lightImpact feedback - [`55d10d6`](https://github.com/AppFlowy-IO/AppFlowy/commit/55d10d6b4b1d201635d6c50a6ea4d45468d6e39c) chore: optimize the action sheet ### 📊 Changes **9 files changed** (+578 additions, -334 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/mobile/document/simple_table_test.dart` (+51 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart` (+14 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_block_component.dart` (+9 -2) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/add_block_menu_item_builder.dart` (+480 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/add_block_toolbar_item.dart` (+7 -324) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_cell_block_component.dart` (+11 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_action_sheet.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_feedback.dart` (+1 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] support showing add block menu in table cell on mobile - [x] exclude the database - [x] exclude the photo gallery - [x] exclude the table - [x] test <img width="566" alt="Screenshot 2024-12-26 at 09 10 07 1" src="https://github.com/user-attachments/assets/ed782033-e0b1-47ca-987b-cd0badcb5b62" /> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:50 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7704
No description provided.