[PR #7091] [MERGED] fix(flutter_desktop): workspace menu ui issues #7728

New issue

Closed

opened 2026-03-23 23:20:56 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7091
Author: @richardshiue
Created: 12/30/2024
Status: ✅ Merged
Merged: 12/30/2024
Merged by: @LucasXu0

Base: main ← Head: fix/workspace-menu-ui

📝 Commits (9)

9646ff6 fix(flutter_desktop): remove log out and workspace option popovers conflict
e1dcb06 test: add integration test
a8551fd fix(flutter_desktop): workspace list scrollbar overlaps with list
048d147 chore(flutter_desktop): fix padding around import from notion button
1fec93b chore(flutter_desktop): adjust popover conflict rules for workspace
7d5e4c8 test: add integration tests
3519814 chore(flutter_desktop): make the popoovers as barriers
93fe4e5 fix: regression from making the workspace item menu as barrier
330cd47 chore: update frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart

📊 Changes

4 files changed (+154 additions, -68 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/collaborative_workspace_test.dart (+66 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart (+30 -11)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart (+57 -51)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart (+1 -0)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7091 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/30/2024 **Status:** ✅ Merged **Merged:** 12/30/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/workspace-menu-ui` --- ### 📝 Commits (9) - [`9646ff6`](https://github.com/AppFlowy-IO/AppFlowy/commit/9646ff65318c3aeb1ed7ab62f8e7bfc2d7226133) fix(flutter_desktop): remove log out and workspace option popovers conflict - [`e1dcb06`](https://github.com/AppFlowy-IO/AppFlowy/commit/e1dcb06c9798b180e8ce3fa582fe55194a926b56) test: add integration test - [`a8551fd`](https://github.com/AppFlowy-IO/AppFlowy/commit/a8551fd6f9daa15b14c70e0c6f418670c9d281b6) fix(flutter_desktop): workspace list scrollbar overlaps with list - [`048d147`](https://github.com/AppFlowy-IO/AppFlowy/commit/048d14763bca1863614ca0134adcb7df6f964fec) chore(flutter_desktop): fix padding around import from notion button - [`1fec93b`](https://github.com/AppFlowy-IO/AppFlowy/commit/1fec93bd823813a45c4b91d6dc02ba657c723cc0) chore(flutter_desktop): adjust popover conflict rules for workspace - [`7d5e4c8`](https://github.com/AppFlowy-IO/AppFlowy/commit/7d5e4c8e0c587dd2aa3af8e64b42f027ddbdf0b2) test: add integration tests - [`3519814`](https://github.com/AppFlowy-IO/AppFlowy/commit/35198146880c80ac6a6ebeb63cd91b43f0cd762d) chore(flutter_desktop): make the popoovers as barriers - [`93fe4e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/93fe4e5f04a753a09040bb431b0f2e4aaff17432) fix: regression from making the workspace item menu as barrier - [`330cd47`](https://github.com/AppFlowy-IO/AppFlowy/commit/330cd472f2d8cc696e4e23a2dc4d6dd7a4698f72) chore: update frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart ### 📊 Changes **4 files changed** (+154 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/collaborative_workspace_test.dart` (+66 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart` (+30 -11) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart` (+57 -51) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart` (+1 -0) </details> ### 📄 Description - [x] [fix(flutter_desktop): remove log out and workspace option popovers co…](https://github.com/AppFlowy-IO/AppFlowy/commit/9646ff65318c3aeb1ed7ab62f8e7bfc2d7226133) (test added) https://github.com/user-attachments/assets/cf452d98-b740-4978-ac85-e7c0c67e023c - [x] [fix(flutter_desktop): workspace list scrollbar overlaps with list](https://github.com/AppFlowy-IO/AppFlowy/commit/a8551fd6f9daa15b14c70e0c6f418670c9d281b6) (no test) (reduced height of popover to show the result) https://github.com/user-attachments/assets/98b7740d-18f2-4390-8e08-c324777943ed - [x] [chore(flutter_desktop): fix padding around import from notion button](https://github.com/AppFlowy-IO/AppFlowy/commit/048d14763bca1863614ca0134adcb7df6f964fec) ![Screenshot 2024-12-30 at 3 40 34 PM](https://github.com/user-attachments/assets/8309f8da-042c-4d58-b96b-17731477334b) - [x] [chore(flutter_desktop): adjust popover conflict rules for workspace](https://github.com/AppFlowy-IO/AppFlowy/commit/1fec93bd823813a45c4b91d6dc02ba657c723cc0) (tests added) https://github.com/user-attachments/assets/1baf3d5c-687a-4b77-9c15-9223034503c3 - [x] [chore(flutter_desktop): make the popoovers as barriers](https://github.com/AppFlowy-IO/AppFlowy/commit/35198146880c80ac6a6ebeb63cd91b43f0cd762d) https://github.com/user-attachments/assets/01ba8615-a4e7-45d2-b52b-cfc2d98df15e ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>