[PR #7113] [MERGED] Fix icon picker issues on mobile #7736

New issue

Closed

opened 2026-03-23 23:20:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7113
Author: @asjqkkkk
Created: 12/31/2024
Status: ✅ Merged
Merged: 1/3/2025
Merged by: @LucasXu0

Base: main ← Head: fix/icons

📝 Commits (9)

aa0e93e fix: error displaying in Page style
5210ff7 fix: error displaying in Favorite/Recent page
6dca21d fix: complete the filter logic of icon picker
1d61dbd fix: the color picker showed when tapping down
326cb38 fix: icons are not supported in subpage blocks
324c422 chore: add some tests
49eee0e fix: recent icons not working for grid header icon
9fa3e30 Merge branch 'main' into fix/icons
4e1f666 Merge branch 'main' into fix/icons

📊 Changes

13 files changed (+239 additions, -63 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart (+43 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_icon_test.dart (+2 -19)
📝 frontend/appflowy_flutter/integration_test/mobile/document/page_style_test.dart (+46 -1)
📝 frontend/appflowy_flutter/integration_test/shared/base.dart (+27 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+18 -0)
📝 frontend/appflowy_flutter/integration_test/shared/emoji.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/shared/mobile_page_card.dart (+8 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_icon.dart (+9 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_block_component.dart (+5 -7)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon.dart (+23 -2)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart (+38 -9)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/recent_icons.dart (+10 -7)
📝 frontend/appflowy_flutter/test/unit_test/util/recent_icons_test.dart (+5 -4)

📄 Description

Fix issue #7101

fix: error displaying in Page style
fix: complete the filter logic of icon picker
fix: error displaying in Favorite/Recent page
fix: the color picker showed when tapping down
fix: icons are not supported in subpage blocks

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7113 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 12/31/2024 **Status:** ✅ Merged **Merged:** 1/3/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/icons` --- ### 📝 Commits (9) - [`aa0e93e`](https://github.com/AppFlowy-IO/AppFlowy/commit/aa0e93e8212d8714c18f88c518ec405f52d64045) fix: error displaying in Page style - [`5210ff7`](https://github.com/AppFlowy-IO/AppFlowy/commit/5210ff78604fc3791d16683cf5b873c3d49b6d6d) fix: error displaying in Favorite/Recent page - [`6dca21d`](https://github.com/AppFlowy-IO/AppFlowy/commit/6dca21d336d3d0e22adc91fde42c87649c379263) fix: complete the filter logic of icon picker - [`1d61dbd`](https://github.com/AppFlowy-IO/AppFlowy/commit/1d61dbd6062f26d79ae441c248f514643019b868) fix: the color picker showed when tapping down - [`326cb38`](https://github.com/AppFlowy-IO/AppFlowy/commit/326cb381873f960eece1aac86eb35fa54785756d) fix: icons are not supported in subpage blocks - [`324c422`](https://github.com/AppFlowy-IO/AppFlowy/commit/324c422b9aebb6bb0b9fdd56f094e57938792b32) chore: add some tests - [`49eee0e`](https://github.com/AppFlowy-IO/AppFlowy/commit/49eee0e55d78ad881d6df12a37e42672ebbf16ae) fix: recent icons not working for grid header icon - [`9fa3e30`](https://github.com/AppFlowy-IO/AppFlowy/commit/9fa3e304f86efa8747ecc96133a57c7d2dfbf351) Merge branch 'main' into fix/icons - [`4e1f666`](https://github.com/AppFlowy-IO/AppFlowy/commit/4e1f6660bbf4aefcb6fcce6ec1fa3d5d97813f81) Merge branch 'main' into fix/icons ### 📊 Changes **13 files changed** (+239 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart` (+43 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_icon_test.dart` (+2 -19) 📝 `frontend/appflowy_flutter/integration_test/mobile/document/page_style_test.dart` (+46 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/base.dart` (+27 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+18 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/emoji.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/shared/mobile_page_card.dart` (+8 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_icon.dart` (+9 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_block_component.dart` (+5 -7) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon.dart` (+23 -2) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart` (+38 -9) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/recent_icons.dart` (+10 -7) 📝 `frontend/appflowy_flutter/test/unit_test/util/recent_icons_test.dart` (+5 -4) </details> ### 📄 Description Fix issue #7101 - fix: error displaying in Page style - fix: complete the filter logic of icon picker - fix: error displaying in Favorite/Recent page - fix: the color picker showed when tapping down - fix: icons are not supported in subpage blocks ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>