[PR #7114] [MERGED] Fix icon picker issues on mobile #7738

New issue

Closed

opened 2026-03-23 23:20:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7114
Author: @asjqkkkk
Created: 12/31/2024
Status: ✅ Merged
Merged: 1/6/2025
Merged by: @LucasXu0

Base: release/0.7.9 ← Head: hotfix/0.7.9

📝 Commits (3)

1e916a0 fix: icon picker issues on mobile (#7113)
6e55d60 fix: recent icon doesn't work in space icon (#7133)
ef648ef Merge branch 'release/0.7.9' into hotfix/0.7.9

📊 Changes

20 files changed (+344 additions, -96 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart (+2 -0)
➕ frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_icon_test.dart (+62 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart (+43 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_icon_test.dart (+2 -19)
📝 frontend/appflowy_flutter/integration_test/mobile/document/page_style_test.dart (+46 -1)
📝 frontend/appflowy_flutter/integration_test/shared/base.dart (+27 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+18 -0)
📝 frontend/appflowy_flutter/integration_test/shared/emoji.dart (+6 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/shared/mobile_page_card.dart (+10 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart (+4 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_icon.dart (+9 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_block_component.dart (+5 -7)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon.dart (+23 -2)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart (+38 -9)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/recent_icons.dart (+14 -7)
📝 frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_header.dart (+16 -15)
📝 frontend/appflowy_flutter/test/unit_test/util/recent_icons_test.dart (+5 -4)

📄 Description

Fix issue #7101

fix: error displaying in Page style
fix: complete the filter logic of icon picker
fix: error displaying in Favorite/Recent page
fix: the color picker showed when tapping down
fix: icons are not supported in subpage blocks

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7114 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 12/31/2024 **Status:** ✅ Merged **Merged:** 1/6/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `release/0.7.9` ← **Head:** `hotfix/0.7.9` --- ### 📝 Commits (3) - [`1e916a0`](https://github.com/AppFlowy-IO/AppFlowy/commit/1e916a02dc2894412e0e3604a0800b1ef1873196) fix: icon picker issues on mobile (#7113) - [`6e55d60`](https://github.com/AppFlowy-IO/AppFlowy/commit/6e55d60225ec5b75dfd020b380df952c4943911a) fix: recent icon doesn't work in space icon (#7133) - [`ef648ef`](https://github.com/AppFlowy-IO/AppFlowy/commit/ef648ef6861443436bf939e6c7a928f53d6b8436) Merge branch 'release/0.7.9' into hotfix/0.7.9 ### 📊 Changes **20 files changed** (+344 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart` (+2 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_icon_test.dart` (+62 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart` (+43 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_icon_test.dart` (+2 -19) 📝 `frontend/appflowy_flutter/integration_test/mobile/document/page_style_test.dart` (+46 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/base.dart` (+27 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+18 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/emoji.dart` (+6 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/shared/mobile_page_card.dart` (+10 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart` (+4 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_icon.dart` (+9 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_block_component.dart` (+5 -7) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon.dart` (+23 -2) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart` (+38 -9) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/recent_icons.dart` (+14 -7) 📝 `frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_header.dart` (+16 -15) 📝 `frontend/appflowy_flutter/test/unit_test/util/recent_icons_test.dart` (+5 -4) </details> ### 📄 Description Fix issue #7101 - fix: error displaying in Page style - fix: complete the filter logic of icon picker - fix: error displaying in Favorite/Recent page - fix: the color picker showed when tapping down - fix: icons are not supported in subpage blocks ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>