[PR #7135] [MERGED] fix: convert false value in attributes to null #7750

New issue

Closed

opened 2026-03-23 23:21:03 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7135
Author: @LucasXu0
Created: 1/3/2025
Status: ✅ Merged
Merged: 1/3/2025
Merged by: @LucasXu0

Base: main ← Head: fix_false_attributes

📝 Commits (1)

28b3fb6 fix: convert false value in attributes to null

📊 Changes

3 files changed (+177 additions, -27 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart (+68 -23)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart (+7 -4)
📝 frontend/appflowy_flutter/test/unit_test/editor/transaction_adapter_test.dart (+102 -0)

📄 Description

Feature Preview

if the value in Delta's attributes is false, we should set the value to null instead. Because on Yjs or YDelta, canceling format must use the null value. If we use false, the update will be rejected.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7135 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 1/3/2025 **Status:** ✅ Merged **Merged:** 1/3/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_false_attributes` --- ### 📝 Commits (1) - [`28b3fb6`](https://github.com/AppFlowy-IO/AppFlowy/commit/28b3fb65e7cc56b01ee33f7acf0de33a4df10697) fix: convert false value in attributes to null ### 📊 Changes **3 files changed** (+177 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart` (+68 -23) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart` (+7 -4) 📝 `frontend/appflowy_flutter/test/unit_test/editor/transaction_adapter_test.dart` (+102 -0) </details> ### 📄 Description   ### Feature Preview if the value in Delta's attributes is false, we should set the value to null instead. Because on Yjs or YDelta, canceling format must use the null value. If we use false, the update will be rejected.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>