[PR #7137] [MERGED] fix: recent icon doesn't work in space icon (#7133) #7752

Closed
opened 2026-03-23 23:21:03 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7137
Author: @asjqkkkk
Created: 1/3/2025
Status: Merged
Merged: 1/5/2025
Merged by: @LucasXu0

Base: mainHead: fix/icons


📝 Commits (1)

  • 94ea4cf fix: recent icon doesn't work in space icon (#7133)

📊 Changes

10 files changed (+107 additions, -35 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart (+2 -0)
frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_icon_test.dart (+62 -0)
📝 frontend/appflowy_flutter/integration_test/shared/emoji.dart (+1 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/shared/mobile_page_card.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart (+4 -7)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/recent_icons.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_header.dart (+16 -15)

📄 Description

Fix the issue #7133

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7137 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 1/3/2025 **Status:** ✅ Merged **Merged:** 1/5/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/icons` --- ### 📝 Commits (1) - [`94ea4cf`](https://github.com/AppFlowy-IO/AppFlowy/commit/94ea4cf6774bdd9813b8aaff61774500b077032e) fix: recent icon doesn't work in space icon (#7133) ### 📊 Changes **10 files changed** (+107 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart` (+2 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_icon_test.dart` (+62 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/emoji.dart` (+1 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/shared/mobile_page_card.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart` (+4 -7) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/recent_icons.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/generate_router.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/sidebar_space_header.dart` (+16 -15) </details> ### 📄 Description Fix the issue #7133 ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:21:03 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7752
No description provided.