[PR #7150] [MERGED] chore: code cleanup #7755

New issue

Closed

opened 2026-03-23 23:21:04 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7150
Author: @richardshiue
Created: 1/6/2025
Status: ✅ Merged
Merged: 1/6/2025
Merged by: @richardshiue

Base: main ← Head: feat/ai-writer

📝 Commits (1)

3eb3212 chore: code cleanup

📊 Changes

27 files changed (+171 additions, -183 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/collaborative_workspace_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/tabs_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/shared/mock/mock_openai_repository.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/ai/ai_client.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/ai/appflowy_ai_service.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/ai/error.dart (+0 -0)
📝 frontend/appflowy_flutter/lib/ai/openai_client.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/ai/text_completion.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_media_cell_editor.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_editor_bloc.dart (+13 -14)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/custom_cover_picker.dart (+78 -68)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/custom_cover_picker_bloc.dart (+17 -17)
➖ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/service/text_edit.dart (+0 -24)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/ai_writer_block_component.dart (+7 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/ask_ai_action_bloc.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/ask_ai_block_component.dart (+2 -2)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/barrier_dialog.dart (+24 -0)
📝 frontend/appflowy_flutter/lib/shared/loading.dart (+0 -21)
📝 frontend/appflowy_flutter/lib/startup/deps_resolver.dart (+2 -2)

...and 7 more files

📄 Description

move loading dialog widget to shared
move ai client to own folder
make ambiguous Loading state private for cover_editor_bloc

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7150 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 1/6/2025 **Status:** ✅ Merged **Merged:** 1/6/2025 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/ai-writer` --- ### 📝 Commits (1) - [`3eb3212`](https://github.com/AppFlowy-IO/AppFlowy/commit/3eb321297e42e5644a10c41071aa48518729c9ed) chore: code cleanup ### 📊 Changes **27 files changed** (+171 additions, -183 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/collaborative_workspace_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/tabs_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/mock/mock_openai_repository.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/ai/ai_client.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/ai/appflowy_ai_service.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/ai/error.dart` (+0 -0) 📝 `frontend/appflowy_flutter/lib/ai/openai_client.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/ai/text_completion.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_media_cell_editor.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_editor_bloc.dart` (+13 -14) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/custom_cover_picker.dart` (+78 -68) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/custom_cover_picker_bloc.dart` (+17 -17) ➖ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/service/text_edit.dart` (+0 -24) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/ai_writer_block_component.dart` (+7 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/ask_ai_action_bloc.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/ask_ai_block_component.dart` (+2 -2) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/barrier_dialog.dart` (+24 -0) 📝 `frontend/appflowy_flutter/lib/shared/loading.dart` (+0 -21) 📝 `frontend/appflowy_flutter/lib/startup/deps_resolver.dart` (+2 -2) _...and 7 more files_ </details> ### 📄 Description - move loading dialog widget to shared - move ai client to own folder - make ambiguous Loading state private for cover_editor_bloc ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>