[PR #7163] [MERGED] fix: can not check text direction automatically on mobile(#7092) #7761

Closed
opened 2026-03-23 23:21:05 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7163
Author: @asjqkkkk
Created: 1/7/2025
Status: Merged
Merged: 1/9/2025
Merged by: @LucasXu0

Base: mainHead: fix/7092


📝 Commits (3)

  • a959e5d fix: can not check text direction automatically on mobile(#7092)
  • 54a11f7 Merge branch 'main' into fix/7092
  • dc74dd5 Merge branch 'main' into fix/7092

📊 Changes

6 files changed (+133 additions, -31 deletions)

View changed files

frontend/appflowy_flutter/integration_test/mobile/settings/default_text_direction_test.dart (+81 -0)
📝 frontend/appflowy_flutter/integration_test/mobile_runner_1.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/rtl_setting.dart (+39 -22)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart (+6 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart (+1 -1)
📝 frontend/appflowy_flutter/test/widget_test/direction_setting_test.dart (+3 -2)

📄 Description

Fix the issue #7092

Enable checking text direction automatically on mobile

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7163 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 1/7/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/7092` --- ### 📝 Commits (3) - [`a959e5d`](https://github.com/AppFlowy-IO/AppFlowy/commit/a959e5de284d29b4ce155248401f004a817cfd09) fix: can not check text direction automatically on mobile(#7092) - [`54a11f7`](https://github.com/AppFlowy-IO/AppFlowy/commit/54a11f783ab7cc40babf10f123450301eb455d9a) Merge branch 'main' into fix/7092 - [`dc74dd5`](https://github.com/AppFlowy-IO/AppFlowy/commit/dc74dd538149b308472c60671cdf09d9c5d61ac6) Merge branch 'main' into fix/7092 ### 📊 Changes **6 files changed** (+133 additions, -31 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/mobile/settings/default_text_direction_test.dart` (+81 -0) 📝 `frontend/appflowy_flutter/integration_test/mobile_runner_1.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/appearance/rtl_setting.dart` (+39 -22) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/appearance_cubit.dart` (+6 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/widget_test/direction_setting_test.dart` (+3 -2) </details> ### 📄 Description Fix the issue #7092 Enable checking text direction automatically on mobile ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:21:05 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7761
No description provided.