[PR #7186] [MERGED] fix: 0.8.1 launch review issues #7774

New issue

Closed

opened 2026-03-23 23:21:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7186
Author: @LucasXu0
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/13/2025
Merged by: @LucasXu0

Base: main ← Head: fix_lr_081

📝 Commits (6)

7db1520 fix: Search result title appears empty
823b744 chore: change "Type to search" to "Search or ask a question…"
186f205 fix: the toolbar shouldn’t over the search panel
869af2f feat: add hint text next to the web url
11334e0 test: the toolbar shouldn’t over the search panel
82930fd test: search result title appears empty

📊 Changes

9 files changed (+196 additions, -53 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/command_palette/folder_search_test.dart (+42 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_view_tile.dart (+6 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_result_tile.dart (+11 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+6 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/sites/domain/domain_item.dart (+23 -21)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart (+17 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart (+56 -21)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/web_url_hint_widget.dart (+34 -0)
📝 frontend/resources/translations/en.json (+1 -1)

📄 Description

Feature Preview

search result title appears empty (test)
change "Type to search" to "Search or ask a question…" (no test required)
the toolbar shouldn’t over the search panel (test)
add hint text and '?' icon next to the web url (no test required)

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7186 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_lr_081` --- ### 📝 Commits (6) - [`7db1520`](https://github.com/AppFlowy-IO/AppFlowy/commit/7db1520aa709e88ac539508e39e5302c992e4058) fix: Search result title appears empty - [`823b744`](https://github.com/AppFlowy-IO/AppFlowy/commit/823b744711774e8edd85805418d47d9b18d36f36) chore: change "Type to search" to "Search or ask a question…" - [`186f205`](https://github.com/AppFlowy-IO/AppFlowy/commit/186f205cf2891df5a3c9ad127ad67b8266921fde) fix: the toolbar shouldn’t over the search panel - [`869af2f`](https://github.com/AppFlowy-IO/AppFlowy/commit/869af2fb594178b0f21720d7fedd08fc24daf21b) feat: add hint text next to the web url - [`11334e0`](https://github.com/AppFlowy-IO/AppFlowy/commit/11334e0b66c652efe2e6c20282a67fe949d56a83) test: the toolbar shouldn’t over the search panel - [`82930fd`](https://github.com/AppFlowy-IO/AppFlowy/commit/82930fd30e9e0422837073d9548b7fa35c3fff6b) test: search result title appears empty ### 📊 Changes **9 files changed** (+196 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/command_palette/folder_search_test.dart` (+42 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_view_tile.dart` (+6 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_result_tile.dart` (+11 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+6 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/sites/domain/domain_item.dart` (+23 -21) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart` (+17 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart` (+56 -21) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/web_url_hint_widget.dart` (+34 -0) 📝 `frontend/resources/translations/en.json` (+1 -1) </details> ### 📄 Description   ### Feature Preview - [x] search result title appears empty (test) - [x] change "Type to search" to "Search or ask a question…" (no test required) - [x] the toolbar shouldn’t over the search panel (test) - [x] add hint text and '?' icon next to the web url (no test required)  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>