[PR #7189] [MERGED] fix: icons not display in search results #7776

New issue

Closed

opened 2026-03-23 23:21:09 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7189
Author: @asjqkkkk
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/13/2025
Merged by: @LucasXu0

Base: main ← Head: fix/icons

📝 Commits (3)

2bda28d fix: icons not display in search results
acc55ad Merge branch 'main' into fix/icons
a2e4f69 chore: clean code

📊 Changes

8 files changed (+227 additions, -65 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/command_palette/folder_search_test.dart (+85 -31)
➕ frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_recent_icon_test.dart (+56 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_test_runner.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/shared/emoji.dart (+1 -6)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart (+16 -12)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/recent_icons.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/command_palette/search_result_ext.dart (+33 -10)
📝 frontend/appflowy_flutter/test/unit_test/util/recent_icons_test.dart (+28 -6)

📄 Description

Fix: icons not display in search results
Fix: skip dirty data in recent icons

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7189 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/icons` --- ### 📝 Commits (3) - [`2bda28d`](https://github.com/AppFlowy-IO/AppFlowy/commit/2bda28d708f88266daf60afd37636223c67c1259) fix: icons not display in search results - [`acc55ad`](https://github.com/AppFlowy-IO/AppFlowy/commit/acc55ad4d4e3815ef3a2c12c20743aefcfe74c2b) Merge branch 'main' into fix/icons - [`a2e4f69`](https://github.com/AppFlowy-IO/AppFlowy/commit/a2e4f6978bbc621292b2e38d0eb90b75d874aba3) chore: clean code ### 📊 Changes **8 files changed** (+227 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/command_palette/folder_search_test.dart` (+85 -31) ➕ `frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_recent_icon_test.dart` (+56 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_test_runner.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/emoji.dart` (+1 -6) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart` (+16 -12) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/recent_icons.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/command_palette/search_result_ext.dart` (+33 -10) 📝 `frontend/appflowy_flutter/test/unit_test/util/recent_icons_test.dart` (+28 -6) </details> ### 📄 Description - Fix: icons not display in search results - Fix: skip dirty data in recent icons ### Feature Preview #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>