[PR #7195] [MERGED] fix: retry count should be clear if the value exceeds max retries #7779

New issue

Closed

opened 2026-03-23 23:21:10 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7195
Author: @LucasXu0
Created: 1/13/2025
Status: ✅ Merged
Merged: 1/13/2025
Merged by: @LucasXu0

Base: main ← Head: clear_retry_count

📝 Commits (3)

a40760b fix: retry count should be clear if the value exceeds max retries
dc7bcb3 Merge branch 'main' into clear_retry_count
fb769f8 feat: add retry button when loading image failed

📊 Changes

4 files changed (+101 additions, -23 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/custom_image_block_component/custom_image_block_component.dart (+11 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/resizeable_image.dart (+27 -6)
📝 frontend/appflowy_flutter/lib/shared/appflowy_network_image.dart (+28 -9)
➕ frontend/appflowy_flutter/test/unit_test/image/appflowy_network_image_test.dart (+35 -0)

📄 Description

Feature Preview

When the maximum retry count exceeds the maxRetries, it should be reset to avoid affecting the next round of image loading, such as when the page is reopened.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7195 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 1/13/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `clear_retry_count` --- ### 📝 Commits (3) - [`a40760b`](https://github.com/AppFlowy-IO/AppFlowy/commit/a40760b9f06d3dfffdf7dcf4235f8417206ba9ac) fix: retry count should be clear if the value exceeds max retries - [`dc7bcb3`](https://github.com/AppFlowy-IO/AppFlowy/commit/dc7bcb35334c6e0e47dc56a03d8d3a33b66b7058) Merge branch 'main' into clear_retry_count - [`fb769f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb769f8eed4e4088d28af2daa10efe7f1a0ff5b7) feat: add retry button when loading image failed ### 📊 Changes **4 files changed** (+101 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/custom_image_block_component/custom_image_block_component.dart` (+11 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/image/resizeable_image.dart` (+27 -6) 📝 `frontend/appflowy_flutter/lib/shared/appflowy_network_image.dart` (+28 -9) ➕ `frontend/appflowy_flutter/test/unit_test/image/appflowy_network_image_test.dart` (+35 -0) </details> ### 📄 Description   ### Feature Preview When the maximum retry count exceeds the `maxRetries`, it should be reset to avoid affecting the next round of image loading, such as when the page is reopened.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>