[PR #7199] [MERGED] chore: remove iconContent from IconsData #7783

New issue

Closed

opened 2026-03-23 23:21:11 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7199
Author: @asjqkkkk
Created: 1/13/2025
Status: ✅ Merged
Merged: 1/14/2025
Merged by: @LucasXu0

Base: main ← Head: fix/icons

📝 Commits (1)

103f68f chore: remove iconContent from IconsData

📊 Changes

9 files changed (+30 additions, -26 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_icon_test.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/desktop/command_palette/folder_search_test.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_callout_test.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+0 -1)
📝 frontend/appflowy_flutter/integration_test/shared/emoji.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/shared/expectation.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/base/icon/icon_widget.dart (+13 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart (+7 -7)

📄 Description

Remove iconContent from IconsData to avoid unnecessary data cost

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7199 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 1/13/2025 **Status:** ✅ Merged **Merged:** 1/14/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/icons` --- ### 📝 Commits (1) - [`103f68f`](https://github.com/AppFlowy-IO/AppFlowy/commit/103f68f2e0a959dd8803b38476d7417b01997c74) chore: remove iconContent from IconsData ### 📊 Changes **9 files changed** (+30 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_icon_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/desktop/command_palette/folder_search_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_callout_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+0 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/emoji.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/expectation.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/base/icon/icon_widget.dart` (+13 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_picker.dart` (+7 -7) </details> ### 📄 Description Remove `iconContent` from `IconsData` to avoid unnecessary data cost ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>