[PR #7257] [MERGED] chore: cancel button not visible in [Reset to Default] for shortcuts(#7171) #7809

New issue

Closed

opened 2026-03-23 23:21:17 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7257
Author: @asjqkkkk
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @LucasXu0

Base: main ← Head: fix/7171

📝 Commits (1)

e3a29c0 chore: cancel button not visible in [Reset to Default] for shortcuts(#7171)

📊 Changes

2 files changed (+27 additions, -27 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart (+19 -15)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/settings_alert_dialog.dart (+8 -12)

📄 Description

Fix the issue: #7171

Before the fix:

After the fix:

dark	light

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7257 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/7171` --- ### 📝 Commits (1) - [`e3a29c0`](https://github.com/AppFlowy-IO/AppFlowy/commit/e3a29c03ade092053687b772fde75effac69488c) chore: cancel button not visible in [Reset to Default] for shortcuts(#7171) ### 📊 Changes **2 files changed** (+27 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart` (+19 -15) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/settings_alert_dialog.dart` (+8 -12) </details> ### 📄 Description Fix the issue: #7171 Before the fix: ![image](https://github.com/user-attachments/assets/b0d6395c-c4dc-4b4c-904c-280229eab9ce) After the fix: dark | light ---|--- ![image](https://github.com/user-attachments/assets/56ab39b8-8cc8-459a-8a81-d86c75997c61) | ![image](https://github.com/user-attachments/assets/6cfd856a-3bd5-4595-aaa0-c98a9e2a85b8) ### Feature Preview ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>