[PR #7270] [MERGED] feat: support upload svg as icon #7817

New issue

Closed

opened 2026-03-23 23:21:20 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7270
Author: @asjqkkkk
Created: 1/23/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @LucasXu0

Base: main ← Head: feat/icon/custom

📝 Commits (7)

26b6117 feat: support upload svg as icon
c9aa178 feat: support upload icon by pasting a link
96524c2 Merge branch 'main' into feat/icon/custom
2dc97f7 feat: delete remote images when remove custon icons
d15f9f5 chore: add testing for pasting image link as custon icon
0a04a22 Merge branch 'main' into feat/icon/custom
fabbfae Merge branch 'main' into feat/icon/custom

📊 Changes

24 files changed (+802 additions, -146 deletions)

View changed files

➕ frontend/appflowy_flutter/assets/test/images/sample.svg (+4 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_icon_test.dart (+96 -12)
📝 frontend/appflowy_flutter/integration_test/mobile/document/icon_test.dart (+55 -16)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+39 -0)
📝 frontend/appflowy_flutter/integration_test/shared/emoji.dart (+38 -0)
📝 frontend/appflowy_flutter/integration_test/shared/expectation.dart (+18 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_quick_actions.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/tab/mobile_space_tab.dart (+8 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart (+102 -37)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_icon_bloc.dart (+1 -1)
➕ frontend/appflowy_flutter/lib/shared/appflowy_network_svg.dart (+197 -0)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/flowy_icon_emoji_picker.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_uploader.dart (+202 -54)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart (+15 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/rename_view_popover.dart (+6 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart (+1 -1)

...and 4 more files

📄 Description

Feature Preview

https://github.com/user-attachments/assets/8af33478-08cc-417d-b6f6-448159a23ee4

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7270 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/icon/custom` --- ### 📝 Commits (7) - [`26b6117`](https://github.com/AppFlowy-IO/AppFlowy/commit/26b611725d4b1bdde67dca4653efe9ffe11a6a16) feat: support upload svg as icon - [`c9aa178`](https://github.com/AppFlowy-IO/AppFlowy/commit/c9aa178e565bcb1d890f11a9a3cf7889509fe8b1) feat: support upload icon by pasting a link - [`96524c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/96524c246cabc28cc11389908ec947c3c8956a97) Merge branch 'main' into feat/icon/custom - [`2dc97f7`](https://github.com/AppFlowy-IO/AppFlowy/commit/2dc97f744b532d48932cd0cf569403899152a10b) feat: delete remote images when remove custon icons - [`d15f9f5`](https://github.com/AppFlowy-IO/AppFlowy/commit/d15f9f54e5bfe75fccccf0bccf5a0c4921fd5347) chore: add testing for pasting image link as custon icon - [`0a04a22`](https://github.com/AppFlowy-IO/AppFlowy/commit/0a04a22d8f8ae7e1cc9073bbc4cc642036f28062) Merge branch 'main' into feat/icon/custom - [`fabbfae`](https://github.com/AppFlowy-IO/AppFlowy/commit/fabbfae2282987eb9d11136c0f85c8fb2c57bd54) Merge branch 'main' into feat/icon/custom ### 📊 Changes **24 files changed** (+802 additions, -146 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/assets/test/images/sample.svg` (+4 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_icon_test.dart` (+96 -12) 📝 `frontend/appflowy_flutter/integration_test/mobile/document/icon_test.dart` (+55 -16) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+39 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/emoji.dart` (+38 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/expectation.dart` (+18 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_view_quick_actions.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/tab/mobile_space_tab.dart` (+8 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart` (+102 -37) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_icon_bloc.dart` (+1 -1) ➕ `frontend/appflowy_flutter/lib/shared/appflowy_network_svg.dart` (+197 -0) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/flowy_icon_emoji_picker.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_uploader.dart` (+202 -54) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_service.dart` (+15 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/rename_view_popover.dart` (+6 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/view_title_bar.dart` (+1 -1) _...and 4 more files_ </details> ### 📄 Description ### Feature Preview https://github.com/user-attachments/assets/8af33478-08cc-417d-b6f6-448159a23ee4 --- #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>