[PR #7281] [MERGED] fix(flutter_desktop): selection going missing while scrolling #7822

Closed
opened 2026-03-23 23:21:21 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7281
Author: @richardshiue
Created: 1/24/2025
Status: Merged
Merged: 2/7/2025
Merged by: @richardshiue

Base: mainHead: fix/chat-message-text-selection


📝 Commits (1)

  • fb85dd7 fix(flutter_desktop)!: selection going missing after scrolling

📊 Changes

3 files changed (+33 additions, -49 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/ai_chat/chat_page.dart (+18 -15)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/user_text_message.dart (+0 -1)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart (+15 -33)

📄 Description

NB: the selectable field of FlowyText has been removed. The recommendation from Flutter is that we use Text + SelectableArea instead of SelectableText.

Also, this PR would work better with a newer version of flutter as this method doesn't work with double tap to select a word and triple tap to select paragraph in the current flutter version (EDIT: Updated to 3.27.4)

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7281 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 1/24/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/chat-message-text-selection` --- ### 📝 Commits (1) - [`fb85dd7`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb85dd7946a0e34ff12cb58adacc21bdb0951609) fix(flutter_desktop)!: selection going missing after scrolling ### 📊 Changes **3 files changed** (+33 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/chat_page.dart` (+18 -15) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/user_text_message.dart` (+0 -1) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text.dart` (+15 -33) </details> ### 📄 Description NB: the selectable field of `FlowyText` has been removed. The recommendation from Flutter is that we use Text + SelectableArea instead of SelectableText. ~~Also, this PR would work better with a newer version of flutter as this method doesn't work with double tap to select a word and triple tap to select paragraph in the current flutter version~~ (EDIT: Updated to 3.27.4) ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:21:21 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7822
No description provided.