[PR #7509] [MERGED] fix: prevent segfault due to infinite recursion in trash view #7925

New issue

Closed

opened 2026-03-23 23:21:49 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7509
Author: @khorshuheng
Created: 3/12/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @khorshuheng

Base: main ← Head: fix-recursion-trash-view

📝 Commits (1)

cbdac71 fix: prevent segfault due to infinite recursion in trash view

📊 Changes

1 file changed (+4 additions, -9 deletions)

View changed files

📝 frontend/rust-lib/flowy-folder/src/manager.rs (+4 -9)

📄 Description

Currently, if the trash's parent and child hierarchy forms a cycle, the app will fail to launch due to segmentation fault, caused by infinite recursion. There is already a method in AppFlowy Collab which address this, so we just need to reuse the same method.

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7509 **Author:** [@khorshuheng](https://github.com/khorshuheng) **Created:** 3/12/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@khorshuheng](https://github.com/khorshuheng) **Base:** `main` ← **Head:** `fix-recursion-trash-view` --- ### 📝 Commits (1) - [`cbdac71`](https://github.com/AppFlowy-IO/AppFlowy/commit/cbdac7102564decdec1dc846477eaa8586d21510) fix: prevent segfault due to infinite recursion in trash view ### 📊 Changes **1 file changed** (+4 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-folder/src/manager.rs` (+4 -9) </details> ### 📄 Description  Currently, if the trash's parent and child hierarchy forms a cycle, the app will fail to launch due to segmentation fault, caused by infinite recursion. There is already a method in AppFlowy Collab which address this, so we just need to reuse the same method.  ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>