[PR #7539] [MERGED] fix: toolbar launch review issues #7948

Closed
opened 2026-03-23 23:21:54 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7539
Author: @asjqkkkk
Created: 3/14/2025
Status: Merged
Merged: 3/14/2025
Merged by: @asjqkkkk

Base: fix/launch_review/0.8.7Head: fix/toolbar


📝 Commits (8)

  • 4d2b321 fix: some launch review issues
  • f5160ac fix: some launch review issues
  • 99b4f3e fix: color picker position error
  • a8db3c2 fix: redesign the dropdown arrow and padding
  • 587ce64 feat: implement toolbar button state
  • 9d7e030 fix: keep custom color not changed
  • 69d0413 feat: revamp color icon in toolbar
  • 4f23ca8 fix: correct toolbar position & add animation for toolbar

📊 Changes

30 files changed (+811 additions, -382 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_option_action_test.dart (+2 -4)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_inline_math_equation_test.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+16 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart (+13 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart (+8 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/ai/ai_writer_toolbar_item.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/ai/operations/ai_writer_entities.dart (+1 -1)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/desktop_floating_toolbar.dart (+81 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/toolbar_animation.dart (+87 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/todo_list_item.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcuts.dart (+4 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart (+10 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_hightlight_color_toolbar_item.dart (+191 -47)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_link_toolbar_item.dart (+7 -2)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_placeholder_toolbar_item.dart (+47 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_align_toolbar_item.dart (+9 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_color_toolbar_item.dart (+189 -48)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart (+21 -13)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_heading_toolbar_item.dart (+45 -114)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart (+28 -66)

...and 10 more files

📄 Description

only for building the package

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7539 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@asjqkkkk](https://github.com/asjqkkkk) **Base:** `fix/launch_review/0.8.7` ← **Head:** `fix/toolbar` --- ### 📝 Commits (8) - [`4d2b321`](https://github.com/AppFlowy-IO/AppFlowy/commit/4d2b32109c20560718acc882e39b89a75b9283cb) fix: some launch review issues - [`f5160ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/f5160acce2380d46c38464e48f1f399e28bb903e) fix: some launch review issues - [`99b4f3e`](https://github.com/AppFlowy-IO/AppFlowy/commit/99b4f3e0fa7d330e7c50e1fae2272aa0f7a4a205) fix: color picker position error - [`a8db3c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/a8db3c25a60169f486c27000b4e6849d63ad84f7) fix: redesign the dropdown arrow and padding - [`587ce64`](https://github.com/AppFlowy-IO/AppFlowy/commit/587ce64e4a656f9a1e74a72637b6f96dc9fdeb23) feat: implement toolbar button state - [`9d7e030`](https://github.com/AppFlowy-IO/AppFlowy/commit/9d7e03001e0f169fb620c9a3d5d1c4ab394e5c7d) fix: keep custom color not changed - [`69d0413`](https://github.com/AppFlowy-IO/AppFlowy/commit/69d04130a6b8383725b6ccbb4f00f52088226974) feat: revamp color icon in toolbar - [`4f23ca8`](https://github.com/AppFlowy-IO/AppFlowy/commit/4f23ca8871506d5abb489f219a48f74b137f0f88) fix: correct toolbar position & add animation for toolbar ### 📊 Changes **30 files changed** (+811 additions, -382 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_option_action_test.dart` (+2 -4) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_inline_math_equation_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+16 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart` (+13 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart` (+8 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/ai/ai_writer_toolbar_item.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/ai/operations/ai_writer_entities.dart` (+1 -1) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/desktop_floating_toolbar.dart` (+81 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/toolbar_animation.dart` (+87 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/todo_list_item.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcuts.dart` (+4 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart` (+10 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_hightlight_color_toolbar_item.dart` (+191 -47) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_link_toolbar_item.dart` (+7 -2) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_placeholder_toolbar_item.dart` (+47 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_align_toolbar_item.dart` (+9 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_color_toolbar_item.dart` (+189 -48) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart` (+21 -13) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_heading_toolbar_item.dart` (+45 -114) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart` (+28 -66) _...and 10 more files_ </details> ### 📄 Description only for building the package ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:21:54 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7948
No description provided.