[PR #7566] [MERGED] fix: some launch review issues #7966

New issue

Closed

opened 2026-03-23 23:21:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:21:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7566
Author: @asjqkkkk
Created: 3/18/2025
Status: ✅ Merged
Merged: 3/18/2025
Merged by: @asjqkkkk

Base: main ← Head: fix/toolbar

📝 Commits (8)

c8f11ea chore: adjust some toolbar text
07588ef chore: change the icons in turn-into menu
6880e16 chore: change the icon in color menu
3d61569 fix: keep selection after doing some changes from toolbar
3eb34ff fix: color menu displaying error
dc16638 fix: wrong filter logic in toolbar suggestion menu
436a17e fix: some launch review issues
102a79d fix: test errors

📊 Changes

17 files changed (+475 additions, -80 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_option_action_test.dart (+4 -4)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_inline_math_equation_test.dart (+0 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart (+20 -20)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/ai/ai_writer_toolbar_item.dart (+1 -1)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/color_picker.dart (+330 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/desktop_floating_toolbar.dart (+4 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart (+49 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_hightlight_color_toolbar_item.dart (+7 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_placeholder_toolbar_item.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_align_toolbar_item.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_color_toolbar_item.dart (+10 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart (+26 -10)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_heading_toolbar_item.dart (+2 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart (+4 -5)
📝 frontend/resources/translations/en.json (+10 -7)

📄 Description

The tooltip text should only upper case the first letter of the first word
Match the new format option names in the Turn Into menu accessed via the six-dot menu
Add a gap of 8px between toolbar and text
Add Shortcut hint at the right side of the menu

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7566 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 3/18/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@asjqkkkk](https://github.com/asjqkkkk) **Base:** `main` ← **Head:** `fix/toolbar` --- ### 📝 Commits (8) - [`c8f11ea`](https://github.com/AppFlowy-IO/AppFlowy/commit/c8f11eaea1d0f180621f0e3a59918c9235b11bca) chore: adjust some toolbar text - [`07588ef`](https://github.com/AppFlowy-IO/AppFlowy/commit/07588ef0ce817d1084172c7f4a9a70ebf2612ff5) chore: change the icons in turn-into menu - [`6880e16`](https://github.com/AppFlowy-IO/AppFlowy/commit/6880e16b85bb1155e960b8e253a2623eefb8c885) chore: change the icon in color menu - [`3d61569`](https://github.com/AppFlowy-IO/AppFlowy/commit/3d61569be076c4810e756b8ef96f969e37844868) fix: keep selection after doing some changes from toolbar - [`3eb34ff`](https://github.com/AppFlowy-IO/AppFlowy/commit/3eb34ff3e710b9890ac180906fd0c75656656585) fix: color menu displaying error - [`dc16638`](https://github.com/AppFlowy-IO/AppFlowy/commit/dc16638153da385a1bc2a46999ef8312a0851b2c) fix: wrong filter logic in toolbar suggestion menu - [`436a17e`](https://github.com/AppFlowy-IO/AppFlowy/commit/436a17e3017f9e89090c665d6dce2d22f82bd99d) fix: some launch review issues - [`102a79d`](https://github.com/AppFlowy-IO/AppFlowy/commit/102a79db14578473d203cdc7b4c2dc33fac36556) fix: test errors ### 📊 Changes **17 files changed** (+475 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_option_action_test.dart` (+4 -4) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_inline_math_equation_test.dart` (+0 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart` (+20 -20) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/ai/ai_writer_toolbar_item.dart` (+1 -1) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/color_picker.dart` (+330 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/desktop_floating_toolbar.dart` (+4 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart` (+49 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_hightlight_color_toolbar_item.dart` (+7 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_placeholder_toolbar_item.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_align_toolbar_item.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_color_toolbar_item.dart` (+10 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart` (+26 -10) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_heading_toolbar_item.dart` (+2 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart` (+4 -5) 📝 `frontend/resources/translations/en.json` (+10 -7) </details> ### 📄 Description - The tooltip text should only upper case the first letter of the first word - Match the new format option names in the Turn Into menu accessed via the six-dot menu - Add a gap of 8px between toolbar and text - Add Shortcut hint at the right side of the menu ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>