[PR #7572] [MERGED] fix: some toolbar text display error #7972

Closed
opened 2026-03-23 23:22:01 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7572
Author: @asjqkkkk
Created: 3/18/2025
Status: Merged
Merged: 3/19/2025
Merged by: @LucasXu0

Base: mainHead: fix/toolbar


📝 Commits (2)

  • e348104 fix: some toolbar text display error
  • 3cd3e57 chore: change string id to enum string id

📊 Changes

12 files changed (+61 additions, -55 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart (+14 -25)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_hightlight_color_toolbar_item.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_link_toolbar_item.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_placeholder_toolbar_item.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_align_toolbar_item.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_color_toolbar_item.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_heading_toolbar_item.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart (+3 -4)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/toolbar_id_enum.dart (+19 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+1 -1)
📝 frontend/resources/translations/en.json (+0 -1)

📄 Description

  • The tooltip text should only upper case the first letter of the first word
  • The tooltip text on windows should not have \
  • Add shortcut hint for some of the more option menu buttons

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7572 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 3/18/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/toolbar` --- ### 📝 Commits (2) - [`e348104`](https://github.com/AppFlowy-IO/AppFlowy/commit/e3481048f52a5733a01176d47fd429fc2de624b4) fix: some toolbar text display error - [`3cd3e57`](https://github.com/AppFlowy-IO/AppFlowy/commit/3cd3e57bf97a18fa9d03316836ace773e7a9e5c7) chore: change string id to enum string id ### 📊 Changes **12 files changed** (+61 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart` (+14 -25) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_hightlight_color_toolbar_item.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_link_toolbar_item.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_placeholder_toolbar_item.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_align_toolbar_item.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_color_toolbar_item.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_heading_toolbar_item.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart` (+3 -4) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/toolbar_id_enum.dart` (+19 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+1 -1) 📝 `frontend/resources/translations/en.json` (+0 -1) </details> ### 📄 Description - The tooltip text should only upper case the first letter of the first word - The tooltip text on windows should not have `\` - Add shortcut hint for some of the `more option` menu buttons ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:22:01 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7972
No description provided.