[PR #7580] [MERGED] fix: using date picker with @ menu get some errors #7980

New issue

Closed

opened 2026-03-23 23:22:04 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7580
Author: @asjqkkkk
Created: 3/20/2025
Status: ✅ Merged
Merged: 3/24/2025
Merged by: @LucasXu0

Base: main ← Head: fix/date_picker

📝 Commits (1)

f21f999 fix: using date picker with @ menu with some errors

📊 Changes

4 files changed (+26 additions, -27 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+0 -9)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker_base.dart (+14 -15)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/desktop_date_picker.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_picker_dialog.dart (+11 -3)

📄 Description

Firstly, change the include time
Then click the reminder, I got an errror

======== Exception caught by gesture library =======================================================
The following assertion was thrown while dispatching a pointer event:
A _PopoverStateNotifier was used after being disposed.

Once you have called dispose() on a _PopoverStateNotifier, it can no longer be used.
When the exception was thrown, this was the stack: 
#0      ChangeNotifier.debugAssertNotDisposed.<anonymous closure> (package:flutter/src/foundation/change_notifier.dart:183:9)
#1      ChangeNotifier.debugAssertNotDisposed (package:flutter/src/foundation/change_notifier.dart:190:6)
#2      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:416:27)
#3      _PopoverStateNotifier.state= (package:appflowy_popover/src/mutex.dart:45:5)
#4      PopoverMutex.state= (package:appflowy_popover/src/mutex.dart:24:55)
#5      PopoverState.showOverlay (package:appflowy_popover/src/popover.dart:221:21)
#6      PopoverState._buildChild.<anonymous closure> (package:appflowy_popover/src/popover.dart:294:9)
#7      PopoverState._callHandler (package:appflowy_popover/src/popover.dart:348:14)
#8      PopoverState._buildClickHandler.<anonymous closure> (package:appflowy_popover/src/popover.dart:322:22)
#9      RenderPointerListener.handleEvent (package:flutter/src/rendering/proxy_box.dart:3084:53)
#10     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:482:22)
#11     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:457:11)
#12     GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:427:7)
#13     GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:390:5)
#14     ScaledWidgetsFlutterBinding._flushPointerEventQueue (package:scaled_app/scaled_app.dart:158:7)
#15     ScaledWidgetsFlutterBinding._handlePointerDataPacket (package:scaled_app/scaled_app.dart:129:9)
#16     _invoke1 (dart:ui/hooks.dart:328:13)
#17     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:450:7)
#18     _dispatchPointerDataPacket (dart:ui/hooks.dart:262:31)
Event: PointerDownEvent#84077(position: Offset(727.2, 727.9))

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7580 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 3/20/2025 **Status:** ✅ Merged **Merged:** 3/24/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/date_picker` --- ### 📝 Commits (1) - [`f21f999`](https://github.com/AppFlowy-IO/AppFlowy/commit/f21f999ca1052058bb82fb42b44e2fa0e483f1ed) fix: using date picker with @ menu with some errors ### 📊 Changes **4 files changed** (+26 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+0 -9) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker_base.dart` (+14 -15) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/desktop_date_picker.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_picker_dialog.dart` (+11 -3) </details> ### 📄 Description <img width="546" alt="image" src="https://github.com/user-attachments/assets/9270d39f-891b-4be2-bba6-bfe0b6fad5d5" /> - Firstly, change the `include time` - Then click the reminder, I got an errror ``` ======== Exception caught by gesture library ======================================================= The following assertion was thrown while dispatching a pointer event: A _PopoverStateNotifier was used after being disposed. Once you have called dispose() on a _PopoverStateNotifier, it can no longer be used. When the exception was thrown, this was the stack: #0 ChangeNotifier.debugAssertNotDisposed.<anonymous closure> (package:flutter/src/foundation/change_notifier.dart:183:9) #1 ChangeNotifier.debugAssertNotDisposed (package:flutter/src/foundation/change_notifier.dart:190:6) #2 ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:416:27) #3 _PopoverStateNotifier.state= (package:appflowy_popover/src/mutex.dart:45:5) #4 PopoverMutex.state= (package:appflowy_popover/src/mutex.dart:24:55) #5 PopoverState.showOverlay (package:appflowy_popover/src/popover.dart:221:21) #6 PopoverState._buildChild.<anonymous closure> (package:appflowy_popover/src/popover.dart:294:9) #7 PopoverState._callHandler (package:appflowy_popover/src/popover.dart:348:14) #8 PopoverState._buildClickHandler.<anonymous closure> (package:appflowy_popover/src/popover.dart:322:22) #9 RenderPointerListener.handleEvent (package:flutter/src/rendering/proxy_box.dart:3084:53) #10 GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:482:22) #11 RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:457:11) #12 GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:427:7) #13 GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:390:5) #14 ScaledWidgetsFlutterBinding._flushPointerEventQueue (package:scaled_app/scaled_app.dart:158:7) #15 ScaledWidgetsFlutterBinding._handlePointerDataPacket (package:scaled_app/scaled_app.dart:129:9) #16 _invoke1 (dart:ui/hooks.dart:328:13) #17 PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:450:7) #18 _dispatchPointerDataPacket (dart:ui/hooks.dart:262:31) Event: PointerDownEvent#84077(position: Offset(727.2, 727.9)) ``` ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>