[PR #7631] [MERGED] fix: toolbar launch review issues #8008

New issue

Closed

opened 2026-03-23 23:22:11 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7631
Author: @asjqkkkk
Created: 3/27/2025
Status: ✅ Merged
Merged: 3/27/2025
Merged by: @LucasXu0

Base: main ← Head: fix/lr/toolbar

📝 Commits (6)

204428b fix: keep the turn into menu within six-dot same as toolbar
bffa4ec fix: change some icon color within toolbar
dd1a1b8 fix: improve toolbar
468edad chore: update editor dependency
3592c1f Merge branch 'main' into fix/lr/toolbar
5bf7f36 fix: update editor dependency

📊 Changes

19 files changed (+707 additions, -402 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+12 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart (+113 -194)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/ai/ai_writer_toolbar_item.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/toolbar_extension.dart (+11 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/desktop_floating_toolbar.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_create_menu.dart (+109 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart (+75 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_link_toolbar_item.dart (+9 -138)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_placeholder_toolbar_item.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_align_toolbar_item.dart (+23 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart (+118 -13)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_heading_toolbar_item.dart (+4 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart (+116 -26)
📝 frontend/appflowy_flutter/lib/startup/startup.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/appearance/desktop_appearance.dart (+8 -3)
➕ frontend/appflowy_flutter/packages/flowy_infra/lib/theme_extension_v2.dart (+91 -0)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)

📄 Description

Turn Into menu has the old design
Collapse more icons into the more menu when the screen is narrow
The slash menu is on t he left side of the cursor
Wrong color of the dropdown arrow

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Improve toolbar and menu interactions in the document editor, focusing on responsive design and user experience for narrow windows

New Features:

Add support for collapsing toolbar items in narrow windows
Implement dynamic toolbar width and layout based on window size

Bug Fixes:

Fix positioning and display of slash menu and dropdown items
Correct color and styling of toolbar icons and dropdowns

Enhancements:

Refactor toolbar and menu interactions to support responsive design
Improve handling of toolbar items in narrow window scenarios
Update theme extensions to support more granular icon and styling controls

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7631 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 3/27/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/lr/toolbar` --- ### 📝 Commits (6) - [`204428b`](https://github.com/AppFlowy-IO/AppFlowy/commit/204428b2b7c611e7b3533feb3e81bb89eeff6fd3) fix: keep the turn into menu within six-dot same as toolbar - [`bffa4ec`](https://github.com/AppFlowy-IO/AppFlowy/commit/bffa4ecc7cb9d97a85416159b52a992aa206c5f4) fix: change some icon color within toolbar - [`dd1a1b8`](https://github.com/AppFlowy-IO/AppFlowy/commit/dd1a1b85aec4c18490c600d480df182befb95bce) fix: improve toolbar - [`468edad`](https://github.com/AppFlowy-IO/AppFlowy/commit/468edadd23c0f29f6d83f874f923826eca5ec9cf) chore: update editor dependency - [`3592c1f`](https://github.com/AppFlowy-IO/AppFlowy/commit/3592c1f9b970c7e5c84c23a09b5de3ab47a013ee) Merge branch 'main' into fix/lr/toolbar - [`5bf7f36`](https://github.com/AppFlowy-IO/AppFlowy/commit/5bf7f364a042ec766fc226a27260a73f42514ab6) fix: update editor dependency ### 📊 Changes **19 files changed** (+707 additions, -402 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+12 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart` (+113 -194) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/ai/ai_writer_toolbar_item.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/toolbar_extension.dart` (+11 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/desktop_floating_toolbar.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_create_menu.dart` (+109 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart` (+75 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_link_toolbar_item.dart` (+9 -138) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_placeholder_toolbar_item.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_align_toolbar_item.dart` (+23 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart` (+118 -13) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_heading_toolbar_item.dart` (+4 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart` (+116 -26) 📝 `frontend/appflowy_flutter/lib/startup/startup.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/appearance/desktop_appearance.dart` (+8 -3) ➕ `frontend/appflowy_flutter/packages/flowy_infra/lib/theme_extension_v2.dart` (+91 -0) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) </details> ### 📄 Description - Turn Into menu has the old design - Collapse more icons into the more menu when the screen is narrow - The slash menu is on t he left side of the cursor - Wrong color of the dropdown arrow ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve toolbar and menu interactions in the document editor, focusing on responsive design and user experience for narrow windows New Features: - Add support for collapsing toolbar items in narrow windows - Implement dynamic toolbar width and layout based on window size Bug Fixes: - Fix positioning and display of slash menu and dropdown items - Correct color and styling of toolbar icons and dropdowns Enhancements: - Refactor toolbar and menu interactions to support responsive design - Improve handling of toolbar items in narrow window scenarios - Update theme extensions to support more granular icon and styling controls --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>