[PR #7639] [MERGED] fix: some toolbar link launch review issues #8014

New issue

Closed

opened 2026-03-23 23:22:13 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7639
Author: @asjqkkkk
Created: 3/27/2025
Status: ✅ Merged
Merged: 3/31/2025
Merged by: @LucasXu0

Base: main ← Head: fix/toolbar/link

📝 Commits (9)

93e2262 fix: some toolbar link launch review issues
d0bf641 fix: support check link format for link menus
b9b6733 fix: toolbar and link hover menu will not display together
e53539a fix: filter link search result with current document id
09e0f44 fix: remove error text while link menu is not focus
427f20d fix: some issues
4bf4910 Merge branch 'main' into fix/toolbar/link
d43745b fix: test errors
1d88bc2 fix: add tooltip for link menu

📊 Changes

14 files changed (+529 additions, -247 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+41 -35)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/desktop_floating_toolbar.dart (+50 -12)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_create_menu.dart (+68 -21)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart (+146 -89)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart (+129 -33)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_search_text_field.dart (+43 -17)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart (+19 -5)
➖ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/toolbar_cubit.dart (+0 -17)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_hightlight_color_toolbar_item.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_link_toolbar_item.dart (+16 -10)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_color_toolbar_item.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart (+7 -5)
📝 frontend/appflowy_flutter/lib/startup/startup.dart (+4 -0)

📄 Description

Fix:

Dark mode issues with link buttons
Display “Untitled” when the pate name is empty
Icon and name are not vertically centered
Show the toast after copy the link
Show the page name instead of the link while hovering on a page link
Hide the toolbar after create a link
Support link validator

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Improve link-related functionality and user experience in the document editor toolbar, addressing various UI and interaction issues

Bug Fixes:

Fix dark mode styling issues with link buttons
Ensure page links display 'Untitled' when the page name is empty
Vertically center icons and names in link displays
Add URL validation for link creation and editing
Show toast notification after copying a link

Enhancements:

Improve link hover menu to show page details
Add dynamic page name and icon display for internal links
Enhance link creation and editing interactions
Improve toolbar button states and color handling

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7639 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 3/31/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/toolbar/link` --- ### 📝 Commits (9) - [`93e2262`](https://github.com/AppFlowy-IO/AppFlowy/commit/93e2262d3a75ca644fb1c6370c70a79cf4c0d898) fix: some toolbar link launch review issues - [`d0bf641`](https://github.com/AppFlowy-IO/AppFlowy/commit/d0bf64165432365e106fcde4f8222266770a2199) fix: support check link format for link menus - [`b9b6733`](https://github.com/AppFlowy-IO/AppFlowy/commit/b9b6733716288903fcbcdd3f04365f8c2125cab2) fix: toolbar and link hover menu will not display together - [`e53539a`](https://github.com/AppFlowy-IO/AppFlowy/commit/e53539a53c42258166d78be1dd8c6e3b42957506) fix: filter link search result with current document id - [`09e0f44`](https://github.com/AppFlowy-IO/AppFlowy/commit/09e0f4454c1363beb6222522f58ff2cc49034921) fix: remove error text while link menu is not focus - [`427f20d`](https://github.com/AppFlowy-IO/AppFlowy/commit/427f20d4f12eb9ef96ce31948c740a5961b7cc5b) fix: some issues - [`4bf4910`](https://github.com/AppFlowy-IO/AppFlowy/commit/4bf4910e71a7e2271fd4832b72245deeba164e4c) Merge branch 'main' into fix/toolbar/link - [`d43745b`](https://github.com/AppFlowy-IO/AppFlowy/commit/d43745b08f4a41ebfa1770e4ddb3d9d0eb067a4e) fix: test errors - [`1d88bc2`](https://github.com/AppFlowy-IO/AppFlowy/commit/1d88bc24c87f6d7b9e691dc7dd950f5e58cc2300) fix: add tooltip for link menu ### 📊 Changes **14 files changed** (+529 additions, -247 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+41 -35) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/desktop_floating_toolbar.dart` (+50 -12) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_create_menu.dart` (+68 -21) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart` (+146 -89) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart` (+129 -33) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_search_text_field.dart` (+43 -17) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart` (+19 -5) ➖ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/toolbar_cubit.dart` (+0 -17) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_format_toolbar_items.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_hightlight_color_toolbar_item.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_link_toolbar_item.dart` (+16 -10) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/custom_text_color_toolbar_item.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/more_option_toolbar_item.dart` (+7 -5) 📝 `frontend/appflowy_flutter/lib/startup/startup.dart` (+4 -0) </details> ### 📄 Description Fix: - Dark mode issues with link buttons - Display “Untitled” when the pate name is empty - Icon and name are not vertically centered - Show the toast after copy the link - Show the page name instead of the link while hovering on a page link - Hide the toolbar after create a link - Support link validator ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve link-related functionality and user experience in the document editor toolbar, addressing various UI and interaction issues Bug Fixes: - Fix dark mode styling issues with link buttons - Ensure page links display 'Untitled' when the page name is empty - Vertically center icons and names in link displays - Add URL validation for link creation and editing - Show toast notification after copying a link Enhancements: - Improve link hover menu to show page details - Add dynamic page name and icon display for internal links - Enhance link creation and editing interactions - Improve toolbar button states and color handling --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>