[PR #7654] [MERGED] fix: some launch review issues for non-search-bar emoji picker #8023

New issue

Closed

opened 2026-03-23 23:22:15 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7654
Author: @asjqkkkk
Created: 3/31/2025
Status: ✅ Merged
Merged: 4/1/2025
Merged by: @LucasXu0

Base: main ← Head: fix/emoji

📝 Commits (4)

48f91ce fix: some launch review issues for emoji picker
d789931 fix: revamp emoji picker which is created by character
39074dd fix: add padding for non-searchbar emoji picker
dd2b719 Merge branch 'main' into fix/emoji

📊 Changes

3 files changed (+263 additions, -125 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart (+129 -79)
📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_menu.dart (+68 -46)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/flowy_tooltip.dart (+66 -0)

📄 Description

Repeated press the arrow keys in emoji menu doesn’t work
Emoji menu position error
Revamp the UI and keyboard events

https://github.com/user-attachments/assets/5558b108-2879-44c3-9c3b-58aefb92a2a8

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Fix emoji picker menu positioning and keyboard navigation issues

Bug Fixes:

Improve emoji menu positioning to handle different editor screen locations
Enable repeated key press handling for arrow keys in emoji menu

Enhancements:

Refactor emoji menu offset calculation to be more robust
Add more flexible positioning logic for emoji menu

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7654 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 4/1/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/emoji` --- ### 📝 Commits (4) - [`48f91ce`](https://github.com/AppFlowy-IO/AppFlowy/commit/48f91ce8521fe0e1038234abe2eac067b2c82003) fix: some launch review issues for emoji picker - [`d789931`](https://github.com/AppFlowy-IO/AppFlowy/commit/d7899312e4c71293ca40af89dfc5d2a40d5419cd) fix: revamp emoji picker which is created by character - [`39074dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/39074dd993486a1861b1162ba3b5096763acac44) fix: add padding for non-searchbar emoji picker - [`dd2b719`](https://github.com/AppFlowy-IO/AppFlowy/commit/dd2b719e4e4efcbfc2598f7751412d51ec6ba0d7) Merge branch 'main' into fix/emoji ### 📊 Changes **3 files changed** (+263 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart` (+129 -79) 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_menu.dart` (+68 -46) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/widget/flowy_tooltip.dart` (+66 -0) </details> ### 📄 Description - Repeated press the arrow keys in emoji menu doesn’t work - Emoji menu position error - Revamp the UI and keyboard events https://github.com/user-attachments/assets/5558b108-2879-44c3-9c3b-58aefb92a2a8 ### Feature Preview #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix emoji picker menu positioning and keyboard navigation issues Bug Fixes: - Improve emoji menu positioning to handle different editor screen locations - Enable repeated key press handling for arrow keys in emoji menu Enhancements: - Refactor emoji menu offset calculation to be more robust - Add more flexible positioning logic for emoji menu --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>