[PR #7661] [MERGED] fix: link menu issues #8030

Closed
opened 2026-03-23 23:22:17 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7661
Author: @asjqkkkk
Created: 3/31/2025
Status: Merged
Merged: 4/1/2025
Merged by: @LucasXu0

Base: mainHead: fix/link


📝 Commits (6)

  • 4ac414e fix: duplicated link menu issue
  • 11748f4 fix: support toolbar animation
  • 69687d7 chore: update appflowy_editor
  • 4ec960c Merge branch 'main' into fix/link
  • d5b8bab fix: update pubspect.lock
  • 0783187 fix: testing error

📊 Changes

8 files changed (+59 additions, -17 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_toolbar_test.dart (+40 -0)
📝 frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart (+4 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart (+4 -1)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)

📄 Description

  • Can not open url without “www”
  • Duplicate the link viewer and abnormal padding
  • Incorrect link edit menu border color
  • Enable floating toolbar animation

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Fix link menu and URL handling issues in the document editor

Bug Fixes:

  • Improve URL handling to automatically add 'https://' prefix for URLs without a protocol
  • Fix link edit menu border color visibility in dark mode
  • Resolve duplicate link viewer and padding issues

Enhancements:

  • Optimize link hover trigger to handle single callback more efficiently

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7661 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 4/1/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/link` --- ### 📝 Commits (6) - [`4ac414e`](https://github.com/AppFlowy-IO/AppFlowy/commit/4ac414e0fe2297b806719a2cda553d6402b5c2c9) fix: duplicated link menu issue - [`11748f4`](https://github.com/AppFlowy-IO/AppFlowy/commit/11748f40f80b9f8c8adc23e0e11d9832d13aae9d) fix: support toolbar animation - [`69687d7`](https://github.com/AppFlowy-IO/AppFlowy/commit/69687d734a42734502f3139bf063c4522a926014) chore: update appflowy_editor - [`4ec960c`](https://github.com/AppFlowy-IO/AppFlowy/commit/4ec960c2607a83ac4765e26ac4babf2a72c7ccef) Merge branch 'main' into fix/link - [`d5b8bab`](https://github.com/AppFlowy-IO/AppFlowy/commit/d5b8bab7c095ad6e3f48259885434292ebc8ef70) fix: update pubspect.lock - [`0783187`](https://github.com/AppFlowy-IO/AppFlowy/commit/07831873c2fc68329ff01f6c21a0a416c030af18) fix: testing error ### 📊 Changes **8 files changed** (+59 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_toolbar_test.dart` (+40 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart` (+4 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart` (+4 -1) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) </details> ### 📄 Description - Can not open url without “www” - Duplicate the link viewer and abnormal padding - Incorrect link edit menu border color - Enable floating toolbar animation ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix link menu and URL handling issues in the document editor Bug Fixes: - Improve URL handling to automatically add 'https://' prefix for URLs without a protocol - Fix link edit menu border color visibility in dark mode - Resolve duplicate link viewer and padding issues Enhancements: - Optimize link hover trigger to handle single callback more efficiently --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:22:17 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8030
No description provided.