[PR #7672] [MERGED] fix: emoji menu should only be triggered when “:” has a followed letter #8037

New issue

Closed

opened 2026-03-23 23:22:19 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7672
Author: @asjqkkkk
Created: 4/2/2025
Status: ✅ Merged
Merged: 4/2/2025
Merged by: @LucasXu0

Base: main ← Head: fix/emoji

📝 Commits (1)

44dcdf3 fix: emoji menu should only be triggered when “:” has a followed letter

📊 Changes

6 files changed (+69 additions, -68 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/uncategorized/emoji_shortcut_test.dart (+4 -11)
📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_actions_command.dart (+38 -11)
📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart (+13 -39)
📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_menu.dart (+11 -4)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)

📄 Description

https://github.com/user-attachments/assets/c596a8f2-3650-4133-8045-826cec0407a4

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Improve emoji menu trigger mechanism to only activate when a colon is followed by a letter

Bug Fixes:

Fix emoji menu activation to require a letter immediately after the colon, preventing unintended emoji menu triggers

Enhancements:

Refactor emoji shortcut handling to add more precise activation conditions
Modify emoji menu initialization to support initial search text

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7672 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/2/2025 **Status:** ✅ Merged **Merged:** 4/2/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/emoji` --- ### 📝 Commits (1) - [`44dcdf3`](https://github.com/AppFlowy-IO/AppFlowy/commit/44dcdf3869b7d7a64ac5a9a1612c9a6cc8268805) fix: emoji menu should only be triggered when “:” has a followed letter ### 📊 Changes **6 files changed** (+69 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/uncategorized/emoji_shortcut_test.dart` (+4 -11) 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_actions_command.dart` (+38 -11) 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart` (+13 -39) 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_menu.dart` (+11 -4) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) </details> ### 📄 Description https://github.com/user-attachments/assets/c596a8f2-3650-4133-8045-826cec0407a4 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve emoji menu trigger mechanism to only activate when a colon is followed by a letter Bug Fixes: - Fix emoji menu activation to require a letter immediately after the colon, preventing unintended emoji menu triggers Enhancements: - Refactor emoji shortcut handling to add more precise activation conditions - Modify emoji menu initialization to support initial search text --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>