[PR #7673] [MERGED] fix: icon and emoji don't align in the mention page menu. #8038

New issue

Closed

opened 2026-03-23 23:22:19 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7673
Author: @LucasXu0
Created: 4/2/2025
Status: ✅ Merged
Merged: 4/9/2025
Merged by: @LucasXu0

Base: main ← Head: recent_page_align

📝 Commits (1)

1142b22 fix: icon and emoji doesn't align in mention page menu

📊 Changes

7 files changed (+33 additions, -24 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/inline_actions/mobile_inline_actions_menu_group.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart (+7 -9)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/child_page.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart (+13 -6)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_result.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+5 -1)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Fix icon and emoji alignment in various menu components by standardizing icon sizing and introducing a more flexible iconBuilder method

Bug Fixes:

Corrected inconsistent icon and emoji sizing across different menu components to ensure visual alignment

Enhancements:

Introduced a more flexible iconBuilder method to replace the previous icon rendering approach
Standardized icon and emoji rendering with consistent sizing and line height

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7673 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 4/2/2025 **Status:** ✅ Merged **Merged:** 4/9/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `recent_page_align` --- ### 📝 Commits (1) - [`1142b22`](https://github.com/AppFlowy-IO/AppFlowy/commit/1142b227c7c226e83061197bbb140bfde92db1a9) fix: icon and emoji doesn't align in mention page menu ### 📊 Changes **7 files changed** (+33 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/inline_actions/mobile_inline_actions_menu_group.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/emoji_icon_widget.dart` (+7 -9) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/child_page.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart` (+13 -6) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/inline_actions_result.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+5 -1) </details> ### 📄 Description   ### Feature Preview <img width="443" alt="Screenshot 2025-04-02 at 11 06 37" src="https://github.com/user-attachments/assets/a7010bc2-de32-4a16-84c4-b181ebd85700" />  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Fix icon and emoji alignment in various menu components by standardizing icon sizing and introducing a more flexible iconBuilder method Bug Fixes: - Corrected inconsistent icon and emoji sizing across different menu components to ensure visual alignment Enhancements: - Introduced a more flexible iconBuilder method to replace the previous icon rendering approach - Standardized icon and emoji rendering with consistent sizing and line height --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>