[PR #7714] [MERGED] fix: overwriting a selected text removes more than expected #8061

Closed
opened 2026-03-23 23:22:26 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7714
Author: @asjqkkkk
Created: 4/9/2025
Status: Merged
Merged: 4/9/2025
Merged by: @LucasXu0

Base: mainHead: fix/7679


📝 Commits (1)

  • 032124c fix: overwriting a selected text removes more than expected

📊 Changes

2 files changed (+39 additions, -4 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_selection_test.dart (+37 -0)
📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_actions_command.dart (+2 -4)

📄 Description

To fix #7679

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Fix text selection and deletion behavior in the document editor

Bug Fixes:

  • Resolve an issue with text selection and deletion where overwriting selected text removes more characters than expected

Tests:

  • Add an integration test to verify text selection and deletion functionality

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7714 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/9/2025 **Status:** ✅ Merged **Merged:** 4/9/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/7679` --- ### 📝 Commits (1) - [`032124c`](https://github.com/AppFlowy-IO/AppFlowy/commit/032124c00284fa461ffcca1245407010e2285a49) fix: overwriting a selected text removes more than expected ### 📊 Changes **2 files changed** (+39 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_selection_test.dart` (+37 -0) 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_actions_command.dart` (+2 -4) </details> ### 📄 Description To fix #7679 ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix text selection and deletion behavior in the document editor Bug Fixes: - Resolve an issue with text selection and deletion where overwriting selected text removes more characters than expected Tests: - Add an integration test to verify text selection and deletion functionality --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:22:26 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8061
No description provided.