[PR #7725] [MERGED] fix: unable to accept the response from 'mark longer' #8069

New issue

Closed

opened 2026-03-23 23:22:28 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7725
Author: @LucasXu0
Created: 4/11/2025
Status: ✅ Merged
Merged: 4/11/2025
Merged by: @LucasXu0

Base: main ← Head: mark_it_longer

📝 Commits (2)

bfe6523 fix: unable to accpet 'make it longer'
79e1d41 fix: markdown text robot test

📊 Changes

2 files changed (+101 additions, -4 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/markdown_text_robot.dart (+37 -4)
📝 frontend/appflowy_flutter/test/unit_test/document/text_robot/markdown_text_robot_test.dart (+64 -0)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Improve markdown text replacement functionality in the document editor to handle full text selection and multi-node markdown conversion

Bug Fixes:

Fix issue with replacing markdown text when the entire text node is selected, ensuring proper node replacement and preservation of subsequent content

Enhancements:

Enhance markdown text robot to handle different selection scenarios, including full node replacement and partial text replacement

Tests:

Add a test case to verify markdown text replacement with selection from start to end of a text node

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7725 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `mark_it_longer` --- ### 📝 Commits (2) - [`bfe6523`](https://github.com/AppFlowy-IO/AppFlowy/commit/bfe65236725346d1274a138889b495c18b0ff432) fix: unable to accpet 'make it longer' - [`79e1d41`](https://github.com/AppFlowy-IO/AppFlowy/commit/79e1d41d987a27ef92b45249a5cad694ef61c8bd) fix: markdown text robot test ### 📊 Changes **2 files changed** (+101 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/markdown_text_robot.dart` (+37 -4) 📝 `frontend/appflowy_flutter/test/unit_test/document/text_robot/markdown_text_robot_test.dart` (+64 -0) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Improve markdown text replacement functionality in the document editor to handle full text selection and multi-node markdown conversion Bug Fixes: - Fix issue with replacing markdown text when the entire text node is selected, ensuring proper node replacement and preservation of subsequent content Enhancements: - Enhance markdown text robot to handle different selection scenarios, including full node replacement and partial text replacement Tests: - Add a test case to verify markdown text replacement with selection from start to end of a text node --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>