[PR #7745] [MERGED] fix: block does not expand with grid size #8082

New issue

Closed

opened 2026-03-23 23:22:31 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7745
Author: @asjqkkkk
Created: 4/14/2025
Status: ✅ Merged
Merged: 4/15/2025
Merged by: @LucasXu0

Base: main ← Head: fix/7732

📝 Commits (2)

630c5a2 fix: block does not expand with grid size
90834c0 fix: replace listenForSizeChanged with SizeChangedLayoutNotifier

📊 Changes

6 files changed (+87 additions, -17 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_view_test.dart (+37 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/tab_bar_view.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart (+6 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/columns/simple_column_block_component.dart (+6 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/columns/simple_column_block_width_resizer.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/columns/simple_columns_block_component.dart (+28 -10)

📄 Description

To fix: #7732

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Fix column block rendering and sizing issues to improve the layout and interaction of columns in the document editor

New Features:

Implement dynamic height tracking for column blocks
Add support for inserting grids into column blocks

Bug Fixes:

Resolve issues with column block expansion and height handling
Improve column block resizer visibility and interaction

Enhancements:

Modify column block component to dynamically adjust height
Add size tracking for column blocks
Enhance column block rendering flexibility

Tests:

Add integration test for inserting a grid into a column

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7745 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/14/2025 **Status:** ✅ Merged **Merged:** 4/15/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/7732` --- ### 📝 Commits (2) - [`630c5a2`](https://github.com/AppFlowy-IO/AppFlowy/commit/630c5a25fd03e16d7e7acca1577fae6f787f043e) fix: block does not expand with grid size - [`90834c0`](https://github.com/AppFlowy-IO/AppFlowy/commit/90834c0d1190cf7bac8fe70e56b31053de3af2fe) fix: replace listenForSizeChanged with SizeChangedLayoutNotifier ### 📊 Changes **6 files changed** (+87 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_view_test.dart` (+37 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/tab_bar_view.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart` (+6 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/columns/simple_column_block_component.dart` (+6 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/columns/simple_column_block_width_resizer.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/columns/simple_columns_block_component.dart` (+28 -10) </details> ### 📄 Description To fix: #7732 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Fix column block rendering and sizing issues to improve the layout and interaction of columns in the document editor New Features: - Implement dynamic height tracking for column blocks - Add support for inserting grids into column blocks Bug Fixes: - Resolve issues with column block expansion and height handling - Improve column block resizer visibility and interaction Enhancements: - Modify column block component to dynamically adjust height - Add size tracking for column blocks - Enhance column block rendering flexibility Tests: - Add integration test for inserting a grid into a column --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>