[PR #7758] [MERGED] fix: error position for slash searching result #8092

Closed
opened 2026-03-23 23:22:34 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7758
Author: @asjqkkkk
Created: 4/15/2025
Status: Merged
Merged: 4/16/2025
Merged by: @LucasXu0

Base: mainHead: fix/mobile/slash_menu


📝 Commits (1)

  • a50c03f fix: error position for slash search result

📊 Changes

2 files changed (+34 additions, -20 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_widget.dart (+32 -20)

📄 Description

Before:

https://github.com/user-attachments/assets/dcf82317-07ae-465c-b5c5-93836210fc23

After:

https://github.com/user-attachments/assets/89dd450a-8047-4809-9148-e2f1f90999e8

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Enhancements:

  • Add a new 'showAtTop' parameter to control the vertical positioning of the selection menu, allowing more flexible menu placement

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7758 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/15/2025 **Status:** ✅ Merged **Merged:** 4/16/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/mobile/slash_menu` --- ### 📝 Commits (1) - [`a50c03f`](https://github.com/AppFlowy-IO/AppFlowy/commit/a50c03f6480a536ddf87d70e02d47c482dda6fa4) fix: error position for slash search result ### 📊 Changes **2 files changed** (+34 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_widget.dart` (+32 -20) </details> ### 📄 Description Before: https://github.com/user-attachments/assets/dcf82317-07ae-465c-b5c5-93836210fc23 After: https://github.com/user-attachments/assets/89dd450a-8047-4809-9148-e2f1f90999e8 ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Enhancements: - Add a new 'showAtTop' parameter to control the vertical positioning of the selection menu, allowing more flexible menu placement --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:22:34 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8092
No description provided.