[PR #7757] [MERGED] fix: auto focus on link name textfield after open the link_edit_menu #8094

Closed
opened 2026-03-23 23:22:35 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7757
Author: @asjqkkkk
Created: 4/15/2025
Status: Merged
Merged: 4/16/2025
Merged by: @LucasXu0

Base: mainHead: fix/desktop/link


📝 Commits (4)

  • eb60d24 fix: auto focus on link name textfield after open the link_edit_menu
  • 29eaf81 Merge branch 'main' into fix/desktop/link
  • bf4d8b1 Merge branch 'main' into fix/desktop/link
  • 0ac28ca chore: update pubspec.yaml

📊 Changes

3 files changed (+100 additions, -70 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart (+97 -67)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)

📄 Description

  • Auto focus on link name textfield after open the LinkEditMenu
  • Press Enter to apply the changes while editing the link name

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Improve link editing experience by adding auto-focus and keyboard interaction for the link name text field

New Features:

  • Enable pressing Enter to apply link changes
  • Add ability to dismiss link edit menu using Escape key

Enhancements:

  • Add auto-focus functionality to the link name text field when the link edit menu opens
  • Implement keyboard event handling to support Enter and Escape keys for applying or dismissing link edits

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7757 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/15/2025 **Status:** ✅ Merged **Merged:** 4/16/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/link` --- ### 📝 Commits (4) - [`eb60d24`](https://github.com/AppFlowy-IO/AppFlowy/commit/eb60d24641133b7cab32aadd8b9c669b08de0660) fix: auto focus on link name textfield after open the link_edit_menu - [`29eaf81`](https://github.com/AppFlowy-IO/AppFlowy/commit/29eaf8106a48034a19c9405680a2e695fa98ec52) Merge branch 'main' into fix/desktop/link - [`bf4d8b1`](https://github.com/AppFlowy-IO/AppFlowy/commit/bf4d8b138c239b6d211da4ff32cec9712e567ecd) Merge branch 'main' into fix/desktop/link - [`0ac28ca`](https://github.com/AppFlowy-IO/AppFlowy/commit/0ac28ca5fd1aae81a0d385f065fa5e419f5a97c7) chore: update pubspec.yaml ### 📊 Changes **3 files changed** (+100 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart` (+97 -67) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) </details> ### 📄 Description - Auto focus on link name textfield after open the LinkEditMenu - Press `Enter` to apply the changes while editing the link name ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve link editing experience by adding auto-focus and keyboard interaction for the link name text field New Features: - Enable pressing Enter to apply link changes - Add ability to dismiss link edit menu using Escape key Enhancements: - Add auto-focus functionality to the link name text field when the link edit menu opens - Implement keyboard event handling to support Enter and Escape keys for applying or dismissing link edits --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:22:35 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8094
No description provided.