[PR #7772] [MERGED] feat: support new design for mobile link #8102

New issue

Closed

opened 2026-03-23 23:22:37 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7772
Author: @asjqkkkk
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/23/2025
Merged by: @LucasXu0

Base: main ← Head: feat/mobile/link

📝 Commits (5)

d9278f7 feat: support new design for mobile link
2964439 Merge branch 'main' into feat/mobile/link
3e61c93 Merge branch 'main' into feat/mobile/link
e5ed7c9 chore: update UI of remove link
d955060 chore: remove LinkUtil and add LinkExtension

📊 Changes

17 files changed (+630 additions, -292 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/mobile/document/toolbar_test.dart (+75 -58)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart (+357 -55)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_header.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_create_menu.dart (+5 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart (+10 -9)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_extension.dart (+39 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart (+25 -46)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_replace_menu.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_search_text_field.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart (+8 -11)
➖ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_item/utils.dart (+0 -23)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/aa_menu/_block_items.dart (+2 -34)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/basic_toolbar_item.dart (+15 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/link_toolbar_item.dart (+71 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/toolbar_item_builder.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+2 -43)
➕ frontend/resources/flowy_icons/20x/mobile_icon_remove_link.svg (+3 -0)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Implement a new mobile link editing experience with improved design and functionality for editing links in the document editor

New Features:

Redesigned mobile link editing bottom sheet with enhanced user interface
Support for both external and internal (page) links
Ability to search and select recent pages when creating links

Enhancements:

Improved link editing workflow on mobile
More flexible link creation and editing process
Better integration with document editing experience

Tests:

Added integration tests for link insertion and editing on mobile
Verified link creation, modification, and removal functionality

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7772 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/23/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/mobile/link` --- ### 📝 Commits (5) - [`d9278f7`](https://github.com/AppFlowy-IO/AppFlowy/commit/d9278f7d2885412f2e0d3a1d28788c9aaa225370) feat: support new design for mobile link - [`2964439`](https://github.com/AppFlowy-IO/AppFlowy/commit/29644393a283bd645aa721ad74b42334919073a1) Merge branch 'main' into feat/mobile/link - [`3e61c93`](https://github.com/AppFlowy-IO/AppFlowy/commit/3e61c9326e769b7050aebbff1aa75e331c79a453) Merge branch 'main' into feat/mobile/link - [`e5ed7c9`](https://github.com/AppFlowy-IO/AppFlowy/commit/e5ed7c95af2a8cfa69d22bed5bc25aadbf86391e) chore: update UI of remove link - [`d955060`](https://github.com/AppFlowy-IO/AppFlowy/commit/d95506032f00cb2e640e4f6d8ef0a810f6569246) chore: remove LinkUtil and add LinkExtension ### 📊 Changes **17 files changed** (+630 additions, -292 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/mobile/document/toolbar_test.dart` (+75 -58) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart` (+357 -55) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_header.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_create_menu.dart` (+5 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart` (+10 -9) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_extension.dart` (+39 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart` (+25 -46) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_replace_menu.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_search_text_field.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart` (+8 -11) ➖ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_item/utils.dart` (+0 -23) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/aa_menu/_block_items.dart` (+2 -34) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/basic_toolbar_item.dart` (+15 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/link_toolbar_item.dart` (+71 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/toolbar_item_builder.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+2 -43) ➕ `frontend/resources/flowy_icons/20x/mobile_icon_remove_link.svg` (+3 -0) </details> ### 📄 Description ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Implement a new mobile link editing experience with improved design and functionality for editing links in the document editor New Features: - Redesigned mobile link editing bottom sheet with enhanced user interface - Support for both external and internal (page) links - Ability to search and select recent pages when creating links Enhancements: - Improved link editing workflow on mobile - More flexible link creation and editing process - Better integration with document editing experience Tests: - Added integration tests for link insertion and editing on mobile - Verified link creation, modification, and removal functionality --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>