[PR #7773] [MERGED] fix: some mention text can not display correctly #8103

Closed
opened 2026-03-23 23:22:37 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7773
Author: @asjqkkkk
Created: 4/17/2025
Status: Merged
Merged: 4/21/2025
Merged by: @LucasXu0

Base: mainHead: fix/link_preview


📝 Commits (2)

  • c3a2551 fix: some mention text can not display correctly
  • 31d5784 fix: remove the image widget from bookmark if the image url is null

📊 Changes

2 files changed (+27 additions, -21 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/custom_link_preview.dart (+14 -16)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/link_parsers/default_parser.dart (+13 -5)

📄 Description

Before:
image

After:
image

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Improve link preview parsing by handling different character encodings more robustly

Bug Fixes:

  • Fix issues with displaying mention text by correctly decoding web page content using appropriate character encodings

Enhancements:

  • Add support for decoding web page content using Latin-1 or UTF-8 encoding based on the content type header

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7773 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/21/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/link_preview` --- ### 📝 Commits (2) - [`c3a2551`](https://github.com/AppFlowy-IO/AppFlowy/commit/c3a2551842570cd9bdeb55b0c2352696c53a724a) fix: some mention text can not display correctly - [`31d5784`](https://github.com/AppFlowy-IO/AppFlowy/commit/31d5784847c573bf03a4cd37990b1c5f4964c40e) fix: remove the image widget from bookmark if the image url is null ### 📊 Changes **2 files changed** (+27 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/custom_link_preview.dart` (+14 -16) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_preview/link_parsers/default_parser.dart` (+13 -5) </details> ### 📄 Description Before: ![image](https://github.com/user-attachments/assets/666f91dd-3abb-4166-b473-6ee71371d1d8) After: ![image](https://github.com/user-attachments/assets/655e855d-d982-4dd2-a706-314c24c6a79b) ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve link preview parsing by handling different character encodings more robustly Bug Fixes: - Fix issues with displaying mention text by correctly decoding web page content using appropriate character encodings Enhancements: - Add support for decoding web page content using Latin-1 or UTF-8 encoding based on the content type header --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:22:37 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8103
No description provided.