[PR #7787] [MERGED] fix: crash when trying to delete emoji #8111

New issue

Closed

opened 2026-03-23 23:22:40 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7787
Author: @asjqkkkk
Created: 4/19/2025
Status: ✅ Merged
Merged: 4/21/2025
Merged by: @LucasXu0

Base: main ← Head: fix/desktop/emoji

📝 Commits (2)

02b67f8 fix: emoji picker error on desktop
945e2ae fix: test errors

📊 Changes

8 files changed (+87 additions, -257 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/uncategorized/emoji_shortcut_test.dart (+44 -28)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/emoji_item.dart (+15 -7)
📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_actions_command.dart (+2 -5)
📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart (+11 -5)
📝 frontend/appflowy_flutter/lib/plugins/emoji/emoji_menu.dart (+4 -6)
➖ frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/emoji_picker/emoji_menu_item.dart (+0 -139)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/emoji_picker/emoji_picker.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/emoji_picker/emoji_shortcut_event.dart (+11 -66)

📄 Description

To Fix: #6849

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refactor and fix emoji picker functionality for desktop, improving error handling and menu display across different platforms

Bug Fixes:

Fixed emoji picker error handling for desktop environments
Improved emoji menu display logic to work correctly across different platforms

Enhancements:

Simplified emoji menu service implementation
Removed platform-specific hardcoded positioning logic
Improved emoji selection and display mechanism

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7787 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/19/2025 **Status:** ✅ Merged **Merged:** 4/21/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/emoji` --- ### 📝 Commits (2) - [`02b67f8`](https://github.com/AppFlowy-IO/AppFlowy/commit/02b67f80bb65cdf4d9ab2f35fedcf6782f4772bc) fix: emoji picker error on desktop - [`945e2ae`](https://github.com/AppFlowy-IO/AppFlowy/commit/945e2ae8acb69f285d44d84c314ab1716f63b2a5) fix: test errors ### 📊 Changes **8 files changed** (+87 additions, -257 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/uncategorized/emoji_shortcut_test.dart` (+44 -28) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/emoji_item.dart` (+15 -7) 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_actions_command.dart` (+2 -5) 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart` (+11 -5) 📝 `frontend/appflowy_flutter/lib/plugins/emoji/emoji_menu.dart` (+4 -6) ➖ `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/emoji_picker/emoji_menu_item.dart` (+0 -139) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/emoji_picker/emoji_picker.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/emoji_picker/emoji_shortcut_event.dart` (+11 -66) </details> ### 📄 Description To Fix: #6849 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Refactor and fix emoji picker functionality for desktop, improving error handling and menu display across different platforms Bug Fixes: - Fixed emoji picker error handling for desktop environments - Improved emoji menu display logic to work correctly across different platforms Enhancements: - Simplified emoji menu service implementation - Removed platform-specific hardcoded positioning logic - Improved emoji selection and display mechanism --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>