[PR #7794] [MERGED] refactor: only notify when user workspaces were changed #8116

New issue

Closed

opened 2026-03-23 23:22:41 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7794
Author: @appflowy
Created: 4/21/2025
Status: ✅ Merged
Merged: 4/21/2025
Merged by: @appflowy

Base: main ← Head: optimize_write_user_workspaces

📝 Commits (3)

1356382 refactor: only notify when user workspaces were changed
7885cb8 chore: fix rust test
2cf96a2 chore: fix rust test

📊 Changes

55 files changed (+546 additions, -553 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/setting/settings_popup_menu.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/tab/mobile_space_tab.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/setting/user_session_setting_group.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/sync/database_sync_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/application/document_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/application/document_collaborators_bloc.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/application/document_sync_bloc.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_util.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_cover_image.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/shared/share/share_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_uploader.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/user/application/password/password_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/user/presentation/anon_user.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/settings_dialog_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_account_view.dart (+11 -7)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart (+2 -2)

...and 35 more files

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refactor workspace synchronization and user profile management to support more granular authentication and workspace handling

Bug Fixes:

Fixed potential issues with user profile and workspace authentication mismatches
Resolved inconsistencies in workspace and user profile management

Enhancements:

Introduced workspace-specific authentication type to differentiate between user and workspace authentication
Improved workspace synchronization logic to only notify when workspace changes occur
Enhanced user profile retrieval to consider workspace context

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7794 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 4/21/2025 **Status:** ✅ Merged **Merged:** 4/21/2025 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `optimize_write_user_workspaces` --- ### 📝 Commits (3) - [`1356382`](https://github.com/AppFlowy-IO/AppFlowy/commit/13563825240acbbcba358eb730485ac14a50c9a9) refactor: only notify when user workspaces were changed - [`7885cb8`](https://github.com/AppFlowy-IO/AppFlowy/commit/7885cb80f4056513765da58a70d188f6b5afa0ed) chore: fix rust test - [`2cf96a2`](https://github.com/AppFlowy-IO/AppFlowy/commit/2cf96a2ce33a49667510ae2cb75b933852b50b3d) chore: fix rust test ### 📊 Changes **55 files changed** (+546 additions, -553 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_view_page.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/setting/settings_popup_menu.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/tab/mobile_space_tab.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/setting/user_session_setting_group.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/sync/database_sync_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_collaborators_bloc.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_sync_bloc.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_util.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/page_style/_page_style_cover_image.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/shared/share/share_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/shared/icon_emoji_picker/icon_uploader.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/user/application/password/password_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/user/presentation/anon_user.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/settings_dialog_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_account_view.dart` (+11 -7) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_workspace_view.dart` (+2 -2) _...and 35 more files_ </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Refactor workspace synchronization and user profile management to support more granular authentication and workspace handling Bug Fixes: - Fixed potential issues with user profile and workspace authentication mismatches - Resolved inconsistencies in workspace and user profile management Enhancements: - Introduced workspace-specific authentication type to differentiate between user and workspace authentication - Improved workspace synchronization logic to only notify when workspace changes occur - Enhanced user profile retrieval to consider workspace context --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>