[PR #7796] [MERGED] fix: canLaunchUrl doesn't work with Flatpak #8118

New issue

Closed

opened 2026-03-23 23:22:41 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7796
Author: @asjqkkkk
Created: 4/21/2025
Status: ✅ Merged
Merged: 4/21/2025
Merged by: @LucasXu0

Base: main ← Head: fix/desktop/linux

📝 Commits (1)

42b5ab5 fix: canLaunchUrl doesn't work with Flatpak

📊 Changes

1 file changed (+10 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart (+10 -2)

📄 Description

To fix #7781

opening an incorrect link will cause a system error dialog to pop up on macOS
so only using canLaunchUrl to check on macOS

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Modify URL launching behavior on macOS to prevent system error dialogs by conditionally using canLaunchUrl

Bug Fixes:

Fix an issue where incorrect URLs on macOS trigger unwanted system error dialogs by conditionally checking URL launchability

Enhancements:

Improve URL launching reliability by adding platform-specific handling for macOS

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7796 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/21/2025 **Status:** ✅ Merged **Merged:** 4/21/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/linux` --- ### 📝 Commits (1) - [`42b5ab5`](https://github.com/AppFlowy-IO/AppFlowy/commit/42b5ab5d6b5e586d516d00d1a9d754a89c3631fb) fix: canLaunchUrl doesn't work with Flatpak ### 📊 Changes **1 file changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart` (+10 -2) </details> ### 📄 Description To fix #7781 opening an incorrect link will cause a system error dialog to pop up on macOS so only using canLaunchUrl to check on macOS ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Modify URL launching behavior on macOS to prevent system error dialogs by conditionally using canLaunchUrl Bug Fixes: - Fix an issue where incorrect URLs on macOS trigger unwanted system error dialogs by conditionally checking URL launchability Enhancements: - Improve URL launching reliability by adding platform-specific handling for macOS --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>