[PR #7801] [MERGED] fix: custom font doesn't apply to settings page #8121

New issue

Closed

opened 2026-03-23 23:22:42 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7801
Author: @LucasXu0
Created: 4/22/2025
Status: ✅ Merged
Merged: 4/22/2025
Merged by: @LucasXu0

Base: main ← Head: font

📝 Commits (3)

14bb59b fix: custom font doesn't apply to settings page
826c5bb chore: update settings page icons
95aafd6 fix: add try catch in http services

📊 Changes

22 files changed (+225 additions, -118 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+6 -2)
📝 frontend/appflowy_flutter/lib/user/application/password/password_http_service.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/members/inivitation/member_http_service.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/members/workspace_member_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart (+12 -11)
📝 frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/data/appflowy_default/semantic.dart (+8 -4)
📝 frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/data/custom/custom_theme.dart (+6 -4)
📝 frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/definition/text_style/base/default_text_style.dart (+97 -77)
📝 frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/definition/text_style/text_style.dart (+20 -8)
📝 frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/definition/theme_data.dart (+7 -2)
➕ frontend/resources/flowy_icons/20x/settings_page_ai.svg (+4 -0)
➕ frontend/resources/flowy_icons/20x/settings_page_bell.svg (+4 -0)
➕ frontend/resources/flowy_icons/20x/settings_page_cloud.svg (+3 -0)
➕ frontend/resources/flowy_icons/20x/settings_page_credit_card.svg (+3 -0)
➕ frontend/resources/flowy_icons/20x/settings_page_database.svg (+3 -0)
➕ frontend/resources/flowy_icons/20x/settings_page_earth.svg (+3 -0)
➕ frontend/resources/flowy_icons/20x/settings_page_keyboard.svg (+11 -0)
➕ frontend/resources/flowy_icons/20x/settings_page_plan.svg (+3 -0)
➕ frontend/resources/flowy_icons/20x/settings_page_user.svg (+4 -0)

...and 2 more files

📄 Description

Feature Preview

apply the custom font in settings page
update settings page icons

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Modify text theme to support custom font application across the application, including settings page

Bug Fixes:

Fix custom font not applying to settings page by updating text style classes to support custom font family

Enhancements:

Introduce a new method to create text styles with a custom font family
Update theme builders to accept an optional font family parameter

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7801 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 4/22/2025 **Status:** ✅ Merged **Merged:** 4/22/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `font` --- ### 📝 Commits (3) - [`14bb59b`](https://github.com/AppFlowy-IO/AppFlowy/commit/14bb59bcf710a0ded46579f0b573474822f1e860) fix: custom font doesn't apply to settings page - [`826c5bb`](https://github.com/AppFlowy-IO/AppFlowy/commit/826c5bb8edfa6ad1b426d168cbd219161313b363) chore: update settings page icons - [`95aafd6`](https://github.com/AppFlowy-IO/AppFlowy/commit/95aafd660f6ba9e63e2f150668694e017cbddbbb) fix: add try catch in http services ### 📊 Changes **22 files changed** (+225 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_style.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+6 -2) 📝 `frontend/appflowy_flutter/lib/user/application/password/password_http_service.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/members/inivitation/member_http_service.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/members/workspace_member_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/settings_menu.dart` (+12 -11) 📝 `frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/data/appflowy_default/semantic.dart` (+8 -4) 📝 `frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/data/custom/custom_theme.dart` (+6 -4) 📝 `frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/definition/text_style/base/default_text_style.dart` (+97 -77) 📝 `frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/definition/text_style/text_style.dart` (+20 -8) 📝 `frontend/appflowy_flutter/packages/appflowy_ui/lib/src/theme/definition/theme_data.dart` (+7 -2) ➕ `frontend/resources/flowy_icons/20x/settings_page_ai.svg` (+4 -0) ➕ `frontend/resources/flowy_icons/20x/settings_page_bell.svg` (+4 -0) ➕ `frontend/resources/flowy_icons/20x/settings_page_cloud.svg` (+3 -0) ➕ `frontend/resources/flowy_icons/20x/settings_page_credit_card.svg` (+3 -0) ➕ `frontend/resources/flowy_icons/20x/settings_page_database.svg` (+3 -0) ➕ `frontend/resources/flowy_icons/20x/settings_page_earth.svg` (+3 -0) ➕ `frontend/resources/flowy_icons/20x/settings_page_keyboard.svg` (+11 -0) ➕ `frontend/resources/flowy_icons/20x/settings_page_plan.svg` (+3 -0) ➕ `frontend/resources/flowy_icons/20x/settings_page_user.svg` (+4 -0) _...and 2 more files_ </details> ### 📄 Description   ### Feature Preview - [x] apply the custom font in settings page - [x] update settings page icons  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Modify text theme to support custom font application across the application, including settings page Bug Fixes: - Fix custom font not applying to settings page by updating text style classes to support custom font family Enhancements: - Introduce a new method to create text styles with a custom font family - Update theme builders to accept an optional font family parameter --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>