[PR #7807] [MERGED] fix: windows scaling issue #8127

New issue

Closed

opened 2026-03-23 23:22:44 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7807
Author: @LucasXu0
Created: 4/22/2025
Status: ✅ Merged
Merged: 4/23/2025
Merged by: @LucasXu0

Base: main ← Head: fix_windows_scale_issue

📝 Commits (2)

e4e5c2f fix: windows scaling issue
c2662d5 Merge branch 'main' into fix_windows_scale_issue

📊 Changes

26 files changed (+198 additions, -106 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/startup/startup.dart (+46 -12)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/appflowy_cloud_task.dart (+7 -4)
📝 frontend/appflowy_flutter/lib/startup/tasks/auto_update_task.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/debug_task.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/device_info_task.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/feature_flag_task.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/file_storage_task.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/hot_key.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/load_plugin.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/localization.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/memory_leak_detector.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/platform_error_catcher.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/platform_service.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/startup/tasks/recent_service_task.dart (+4 -5)
📝 frontend/appflowy_flutter/lib/startup/tasks/rust_sdk.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/sentry.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/windows.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/desktop_sign_in_screen.dart (+15 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/command_palette/command_palette_bloc.dart (+5 -1)

...and 6 more files

📄 Description

Feature Preview

scaling issue on Windows
continue investigating password issue on Windows
launch tasks: potential thread race issue
add info logs to trace the launch task steps

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Improve Windows scaling and launch task handling by adding synchronization, logging, and window focus state management

Bug Fixes:

Fix Windows scaling issues by adding window focus state management
Prevent potential race conditions in launch tasks through synchronization

Enhancements:

Add logging to track dispatch and launch task initialization
Improve task initialization and disposal with consistent logging
Enhance window focus handling for better UI responsiveness

Chores:

Refactor launch task base class to include default logging
Update window manager dependency

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7807 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 4/22/2025 **Status:** ✅ Merged **Merged:** 4/23/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_windows_scale_issue` --- ### 📝 Commits (2) - [`e4e5c2f`](https://github.com/AppFlowy-IO/AppFlowy/commit/e4e5c2f1f455c02211257a2fd09a5955c1fbfb79) fix: windows scaling issue - [`c2662d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/c2662d5d06433693a7e85918bf3c713b984dc80e) Merge branch 'main' into fix_windows_scale_issue ### 📊 Changes **26 files changed** (+198 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/startup/startup.dart` (+46 -12) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/appflowy_cloud_task.dart` (+7 -4) 📝 `frontend/appflowy_flutter/lib/startup/tasks/auto_update_task.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/debug_task.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/device_info_task.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/feature_flag_task.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/file_storage_task.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/hot_key.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/load_plugin.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/localization.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/memory_leak_detector.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/platform_error_catcher.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/platform_service.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/startup/tasks/recent_service_task.dart` (+4 -5) 📝 `frontend/appflowy_flutter/lib/startup/tasks/rust_sdk.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/sentry.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/windows.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/desktop_sign_in_screen.dart` (+15 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/command_palette/command_palette_bloc.dart` (+5 -1) _...and 6 more files_ </details> ### 📄 Description   ### Feature Preview - [x] scaling issue on Windows - [x] continue investigating password issue on Windows - [x] launch tasks: potential thread race issue - [x] add info logs to trace the launch task steps  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve Windows scaling and launch task handling by adding synchronization, logging, and window focus state management Bug Fixes: - Fix Windows scaling issues by adding window focus state management - Prevent potential race conditions in launch tasks through synchronization Enhancements: - Add logging to track dispatch and launch task initialization - Improve task initialization and disposal with consistent logging - Enhance window focus handling for better UI responsiveness Chores: - Refactor launch task base class to include default logging - Update window manager dependency --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>