[PR #7825] [MERGED] fix: some notification center launch review issues #8142

Closed
opened 2026-03-23 23:22:48 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7825
Author: @asjqkkkk
Created: 4/24/2025
Status: Merged
Merged: 4/28/2025
Merged by: @LucasXu0

Base: mainHead: fix/launch_review_notification


📝 Commits (10+)

  • a55fc09 fix: some notification center UI issues
  • 3fb3026 fix: add number to add dot on mobile
  • f182b1e chore: revamp number red dot
  • 04530be fix: apply tokens for notification center
  • e3e36d4 Merge branch 'main' into fix/launch_review_notification
  • ba80142 fix: change some token value
  • ca73ba6 chore: change notification at to icon
  • ca0a157 Merge branch 'main' into fix/launch_review_notification
  • dd19f51 fix: revamp reminder bloc
  • b8a7466 fix: test errors

📊 Changes

32 files changed (+792 additions, -525 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_date_reminder_test.dart (+8 -8)
📝 frontend/appflowy_flutter/integration_test/mobile/document/toolbar_test.dart (+6 -1)
📝 frontend/appflowy_flutter/lib/mobile/application/notification/notification_reminder_bloc.dart (+14 -17)
📝 frontend/appflowy_flutter/lib/mobile/presentation/mobile_bottom_navigation_bar.dart (+22 -17)
📝 frontend/appflowy_flutter/lib/mobile/presentation/notifications/mobile_notifications_page.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/multi_select_notification_item.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/notification_item.dart (+14 -12)
📝 frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/shared.dart (+36 -28)
📝 frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/slide_actions.dart (+32 -30)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart (+10 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_embed/link_embed_block_component.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+30 -19)
frontend/appflowy_flutter/lib/shared/red_dot.dart (+0 -25)
📝 frontend/appflowy_flutter/lib/user/application/reminder/reminder_bloc.dart (+227 -81)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/header/sidebar_top_menu.dart (+12 -7)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/header/sidebar_user.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/shared/sidebar_setting.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart (+10 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/navigation.dart (+1 -5)

...and 12 more files

📄 Description

  • number is not aligned cetner
  • some text content modification
  • show number of notification in the mobile tab

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Fix notification center UI and UX issues, including number alignment, text content modifications, and displaying notification count in the mobile tab

New Features:

  • Added support for showing number of unread notifications with '99+' for large counts

Bug Fixes:

  • Corrected spelling of 'archived' in various notification-related strings
  • Fixed alignment and display of unread notification numbers
  • Improved text overflow handling in notification content

Enhancements:

  • Redesigned numbered red dot to handle multiple digit notification counts
  • Improved notification item layout and spacing
  • Enhanced notification icon and text styling

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7825 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/launch_review_notification` --- ### 📝 Commits (10+) - [`a55fc09`](https://github.com/AppFlowy-IO/AppFlowy/commit/a55fc095c4abcbfa639afccbea22a07d163d93c6) fix: some notification center UI issues - [`3fb3026`](https://github.com/AppFlowy-IO/AppFlowy/commit/3fb3026626a38794e09f055885cc8fb4f07d7816) fix: add number to add dot on mobile - [`f182b1e`](https://github.com/AppFlowy-IO/AppFlowy/commit/f182b1ee21420f8519a0a2f79817ce7df4ec3b64) chore: revamp number red dot - [`04530be`](https://github.com/AppFlowy-IO/AppFlowy/commit/04530be865819a6fda5492f3b9802343bd325750) fix: apply tokens for notification center - [`e3e36d4`](https://github.com/AppFlowy-IO/AppFlowy/commit/e3e36d404e9b1b1ba1dfc047a6e52c770cbf7062) Merge branch 'main' into fix/launch_review_notification - [`ba80142`](https://github.com/AppFlowy-IO/AppFlowy/commit/ba801421b43066649693dcce57719dad2f04e5ed) fix: change some token value - [`ca73ba6`](https://github.com/AppFlowy-IO/AppFlowy/commit/ca73ba69b86cb8dc45c52a54bc348eb71d913dc0) chore: change notification at to icon - [`ca0a157`](https://github.com/AppFlowy-IO/AppFlowy/commit/ca0a1570c7c47dd722a2d15ff1164bb6a9ef0aa4) Merge branch 'main' into fix/launch_review_notification - [`dd19f51`](https://github.com/AppFlowy-IO/AppFlowy/commit/dd19f518f6c4d360d4f934fae51241aebd9ce9b9) fix: revamp reminder bloc - [`b8a7466`](https://github.com/AppFlowy-IO/AppFlowy/commit/b8a74663c19376768ce7e07e06628ebbace95638) fix: test errors ### 📊 Changes **32 files changed** (+792 additions, -525 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_date_reminder_test.dart` (+8 -8) 📝 `frontend/appflowy_flutter/integration_test/mobile/document/toolbar_test.dart` (+6 -1) 📝 `frontend/appflowy_flutter/lib/mobile/application/notification/notification_reminder_bloc.dart` (+14 -17) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/mobile_bottom_navigation_bar.dart` (+22 -17) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/notifications/mobile_notifications_page.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/multi_select_notification_item.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/notification_item.dart` (+14 -12) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/shared.dart` (+36 -28) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/notifications/widgets/slide_actions.dart` (+32 -30) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart` (+10 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/link_embed/link_embed_block_component.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+30 -19) ➖ `frontend/appflowy_flutter/lib/shared/red_dot.dart` (+0 -25) 📝 `frontend/appflowy_flutter/lib/user/application/reminder/reminder_bloc.dart` (+227 -81) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/header/sidebar_top_menu.dart` (+12 -7) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/header/sidebar_user.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/shared/sidebar_setting.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart` (+10 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/navigation.dart` (+1 -5) _...and 12 more files_ </details> ### 📄 Description - number is not aligned cetner - some text content modification - show number of notification in the mobile tab ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix notification center UI and UX issues, including number alignment, text content modifications, and displaying notification count in the mobile tab New Features: - Added support for showing number of unread notifications with '99+' for large counts Bug Fixes: - Corrected spelling of 'archived' in various notification-related strings - Fixed alignment and display of unread notification numbers - Improved text overflow handling in notification content Enhancements: - Redesigned numbered red dot to handle multiple digit notification counts - Improved notification item layout and spacing - Enhanced notification icon and text styling --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:22:48 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8142
No description provided.