mirror of
https://github.com/AppFlowy-IO/AppFlowy.git
synced 2026-03-24 12:56:59 +00:00
[GH-ISSUE #2041] [Bug] Text in 'Show menu' tooltip and font size switcher didn't get translated #815
Labels
No labels
2024
2025
2026
acct mgmt
AI
automation
bug
calendar
ci
CJK
cloud
code-block
collaboration
copy-paste
database
data migration
data sync
deploy
desktop
develop
develop
documentation
duplicate
editor
editor-plugin
emoji
export
files
flutter-only
follow-up
formula
good first issue for devs
good first issue for experienced devs
grid
hacktoberfest
HACKTOBERFEST-ACCEPTED
help wanted
i18n
icons
images
importer
improvements
infra
install
integrations
IR
kanban board
login
look and joy
mentorship
mobile
mobile
needs design
new feature
new feature
non-coding
notes
notifications
onboarding
organization
P0+
permission
platform-linux
platform-mac
platform-windows
plugins
program
pull-request
Q1 25
Q1 26
Q2 24
Q2 25
Q3 24
Q3 25
Q4 24
Q4 25
react
regression
rust
rust
Rust-only
Rust-only
Rust-starter
Rust-starter
self-hosted
shortcuts
side panel
slash-menu
sync v2
table
tablet
task
tauri
templates
tests
themes
translation
v0.5.6
v0.5.8
v0.5.9
v0.6.0
v0.6.1
v0.6.4
v0.6.7
v0.6.8
v0.7.1
v0.7.4
v0.7.4
v0.7.5
v0.7.6
v0.7.7
v0.7.8
v0.8.0
v0.8.4
v0.8.5
v0.8.9
web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
AppFlowy-IO/AppFlowy#815
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hyj1204 on GitHub (Mar 20, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/2041
Originally assigned to: @hmncube on GitHub.
Bug Description
No matter which language I select, the text for the 'Show menu' tooltip and font size switcher always appears English.
How to Reproduce
Click on the 'more' icon located in the top-right corner.
Expected Behavior
Display the texts in the language selected by the user.
If we do not have an appropriate translation yet, it is recommended to keep the text in its original English language in the corresponding JSON file until a suitable translation is available.
Operating System
macOS 13.0
AppFlowy Version(s)
0.1.1
Screenshots
'Show menu' tooltip

FontSizeSwitcher

Additional Context
No response
@hmncube commented on GitHub (May 12, 2023):
@hyj1204 For this do I add the English words and then someone will translate to other languages? Also, it seems the font switcher has been translated in the latest version.

@hyj1204 commented on GitHub (May 12, 2023):
@hmncube

You can add the phrase "More options" to
en.jsonfile which has all the localized words in English.Then Rebuild the app, this step will generate/update the
Locale_Keysfiles.After it, add a tooltip value to
PopupMenuButtonin themore_button.dartby using the LocaleKeys.It may look like '
tooltip: LocaleKeys.moreAction_tooltipText.tr().If you got aisn't definederror, adding the following import will solve it.I noticed that the font size part has already been linked to LocaleKey, the reason why it didn't change is lacking translation in some languages. so there is nothing that needs to be fixed.