[PR #7836] [MERGED] fix: some mobile search LR issues #8150

New issue

Closed

opened 2026-03-23 23:22:50 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7836
Author: @asjqkkkk
Created: 4/26/2025
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @LucasXu0

Base: main ← Head: fix/mobile/search

📝 Commits (1)

9186a51 fix: some mobile search LR issues

📊 Changes

10 files changed (+120 additions, -90 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/mobile/search/search_test.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/application/notification/notification_reminder_bloc.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_cell.dart (+20 -43)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_page.dart (+55 -29)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_result.dart (+15 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart (+12 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/workspace/application/command_palette/search_result_ext.dart (+10 -2)
📝 frontend/resources/translations/en.json (+2 -2)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refactor mobile search page to improve layout and keyboard focus handling.

Bug Fixes:

Filter out trashed items from the recent search list.
Prevent potential errors in notification reminders if the associated view is missing.
Log an error if a tapped search result view cannot be found.
Ensure search input loses focus when navigating away from the search tab.
Dismiss keyboard when scrolling search results on mobile.
Update translation key for 'Best Matches' text in search results.
Pass icon color correctly for search result icons.
Remove redundant SafeArea widget from mobile search screen.
Update border radius for link input field in mobile bottom sheet.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7836 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/26/2025 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/mobile/search` --- ### 📝 Commits (1) - [`9186a51`](https://github.com/AppFlowy-IO/AppFlowy/commit/9186a51f3fcc0c9313e22830a9bb1bdc8dc4acb2) fix: some mobile search LR issues ### 📊 Changes **10 files changed** (+120 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/mobile/search/search_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/application/notification/notification_reminder_bloc.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_cell.dart` (+20 -43) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_page.dart` (+55 -29) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_result.dart` (+15 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart` (+12 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/workspace/application/command_palette/search_result_ext.dart` (+10 -2) 📝 `frontend/resources/translations/en.json` (+2 -2) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Refactor mobile search page to improve layout and keyboard focus handling. Bug Fixes: - Filter out trashed items from the recent search list. - Prevent potential errors in notification reminders if the associated view is missing. - Log an error if a tapped search result view cannot be found. - Ensure search input loses focus when navigating away from the search tab. - Dismiss keyboard when scrolling search results on mobile. - Update translation key for 'Best Matches' text in search results. - Pass icon color correctly for search result icons. - Remove redundant SafeArea widget from mobile search screen. - Update border radius for link input field in mobile bottom sheet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>