[PR #7842] [MERGED] feat: improve password error message #8156

New issue

Closed

opened 2026-03-23 23:22:52 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7842
Author: @LucasXu0
Created: 4/28/2025
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @LucasXu0

Base: main ← Head: password_error_message

📝 Commits (4)

edeff32 chore: update i18n
5f0ea79 chore: bump client api version
3f06f64 chore: try to fix the mobile build
014a9dd chore: enable iOS CI

📊 Changes

9 files changed (+272 additions, -175 deletions)

View changed files

📝 .github/workflows/ios_ci.yaml (+23 -23)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/account_deletion.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/password/change_password.dart (+17 -15)
➕ frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/password/error_extensions.dart (+39 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/password/setup_password.dart (+20 -11)
📝 frontend/resources/translations/en.json (+3 -2)
📝 frontend/rust-lib/Cargo.lock (+13 -13)
📝 frontend/rust-lib/Cargo.toml (+3 -3)
📝 frontend/rust-lib/flowy-ai/src/local_ai/controller.rs (+154 -107)

📄 Description

Feature Preview

improve password error message
bump client-api version

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Refactor password error handling to provide more specific feedback and update backend client dependencies.

Enhancements:

Display specific password validation errors directly within the input fields.
Centralize password error message parsing and localization logic.

Build:

Update client-api, client-api-entity, and workspace-template dependencies to a newer revision.

Chores:

Adjust layout alignment in the account deletion section.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7842 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 4/28/2025 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `password_error_message` --- ### 📝 Commits (4) - [`edeff32`](https://github.com/AppFlowy-IO/AppFlowy/commit/edeff32903492530140c29924ef8ed91d99142ef) chore: update i18n - [`5f0ea79`](https://github.com/AppFlowy-IO/AppFlowy/commit/5f0ea79bdd0a62cb21d2cc16ff3edae110f31f5b) chore: bump client api version - [`3f06f64`](https://github.com/AppFlowy-IO/AppFlowy/commit/3f06f6415aee635e1e39cc772ece081484f0ab14) chore: try to fix the mobile build - [`014a9dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/014a9dd820d358511f0ecfa6d51092f0bd5b5d2e) chore: enable iOS CI ### 📊 Changes **9 files changed** (+272 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ios_ci.yaml` (+23 -23) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/account_deletion.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/password/change_password.dart` (+17 -15) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/password/error_extensions.dart` (+39 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/password/setup_password.dart` (+20 -11) 📝 `frontend/resources/translations/en.json` (+3 -2) 📝 `frontend/rust-lib/Cargo.lock` (+13 -13) 📝 `frontend/rust-lib/Cargo.toml` (+3 -3) 📝 `frontend/rust-lib/flowy-ai/src/local_ai/controller.rs` (+154 -107) </details> ### 📄 Description   ### Feature Preview - [x] improve password error message - [x] bump client-api version  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Refactor password error handling to provide more specific feedback and update backend client dependencies. Enhancements: - Display specific password validation errors directly within the input fields. - Centralize password error message parsing and localization logic. Build: - Update `client-api`, `client-api-entity`, and `workspace-template` dependencies to a newer revision. Chores: - Adjust layout alignment in the account deletion section. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>