[PR #7848] [MERGED] fix: some lr issues #8161

New issue

Closed

opened 2026-03-23 23:22:53 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7848
Author: @asjqkkkk
Created: 4/28/2025
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @LucasXu0

Base: main ← Head: fix/desktop/lr

📝 Commits (2)

c97fcb2 fix: some lr issues
f8e3175 Merge branch 'main' into fix/desktop/lr

📊 Changes

3 files changed (+7 additions, -10 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart (+2 -8)

📄 Description

On Windows, click to open an inline link doesn’t work for appflowy.com (no https://) as the link
On Windows, the link menu doesn’t close automatically after I click Apply
The sidebar collapse/uncollapse is broken. The shortcut is not working either. The shortcut displayed in the tooltip on hover is also not the right one.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Fix link handling on Windows and restore sidebar toggle functionality.

Bug Fixes:

Allow opening links without an explicit protocol (e.g., "appflowy.com") on Windows.
Close the link editing popover automatically after clicking 'Apply'.
Restore the expand/collapse functionality of the sidebar toggle button.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7848 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/28/2025 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/lr` --- ### 📝 Commits (2) - [`c97fcb2`](https://github.com/AppFlowy-IO/AppFlowy/commit/c97fcb2fbd75cefc450bb4417533dac4623cad85) fix: some lr issues - [`f8e3175`](https://github.com/AppFlowy-IO/AppFlowy/commit/f8e3175d0e5a9520383f5749500c0c39837cd130) Merge branch 'main' into fix/desktop/lr ### 📊 Changes **3 files changed** (+7 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart` (+2 -8) </details> ### 📄 Description - [x] On Windows, click to open an inline link doesn’t work for [appflowy.com](http://appflowy.com/) (no https://) as the link - [x] On Windows, the link menu doesn’t close automatically after I click Apply - [x] The sidebar collapse/uncollapse is broken. The shortcut is not working either. The shortcut displayed in the tooltip on hover is also not the right one. ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix link handling on Windows and restore sidebar toggle functionality. Bug Fixes: - Allow opening links without an explicit protocol (e.g., "appflowy.com") on Windows. - Close the link editing popover automatically after clicking 'Apply'. - Restore the expand/collapse functionality of the sidebar toggle button. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>