[PR #7863] fix: edit link will break the text styles #8173

New issue

Open

opened 2026-03-23 23:22:57 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:22:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7863
Author: @asjqkkkk
Created: 4/30/2025
Status: 🔄 Open

Base: main ← Head: fix/desktop/link

📝 Commits (5)

ea1e0f7 fix: edit link will break the text styles
f75d061 Merge branch 'main' into fix/desktop/link
4651316 fix: remove key error
5709b94 Merge branch 'main' into fix/desktop/link
14447f6 Merge branch 'main' into fix/desktop/link

📊 Changes

3 files changed (+118 additions, -37 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_toolbar_test.dart (+74 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_extension.dart (+43 -10)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart (+1 -26)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Fix an issue with editing links that could potentially break text styles in the document editor

Bug Fixes:

Preserve text styles (bold, italic, underline) when editing or removing links

Enhancements:

Improve link editing functionality to maintain existing text attributes

Tests:

Added integration test to verify link editing with styled text

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7863 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 4/30/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/desktop/link` --- ### 📝 Commits (5) - [`ea1e0f7`](https://github.com/AppFlowy-IO/AppFlowy/commit/ea1e0f7c37105666090b13017db9384a164a3c71) fix: edit link will break the text styles - [`f75d061`](https://github.com/AppFlowy-IO/AppFlowy/commit/f75d0618cdedcb507082fdb90ec642e15ecfd578) Merge branch 'main' into fix/desktop/link - [`4651316`](https://github.com/AppFlowy-IO/AppFlowy/commit/4651316e7583cbc0b241f30863187d60d81aeb98) fix: remove key error - [`5709b94`](https://github.com/AppFlowy-IO/AppFlowy/commit/5709b9493adadf987e4999b7c034dc5b438f5102) Merge branch 'main' into fix/desktop/link - [`14447f6`](https://github.com/AppFlowy-IO/AppFlowy/commit/14447f65d011ff33949db5d415ea03b46da97230) Merge branch 'main' into fix/desktop/link ### 📊 Changes **3 files changed** (+118 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_toolbar_test.dart` (+74 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_extension.dart` (+43 -10) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart` (+1 -26) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix an issue with editing links that could potentially break text styles in the document editor Bug Fixes: - Preserve text styles (bold, italic, underline) when editing or removing links Enhancements: - Improve link editing functionality to maintain existing text attributes Tests: - Added integration test to verify link editing with styled text --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>