[PR #7896] [CLOSED] fix: remove empty paragraphs after inserting file block #8190

Closed
opened 2026-03-23 23:23:02 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7896
Author: @LucasXu0
Created: 5/8/2025
Status: Closed

Base: mainHead: main


📄 Description

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Improve file block insertion behavior by replacing empty paragraphs with file blocks and maintaining non-empty paragraph content

New Features:

  • Add logic to replace empty paragraphs with file blocks when inserting

Bug Fixes:

  • Fix issue with unnecessary paragraph creation when inserting file blocks

Tests:

  • Add unit tests for file block insertion in different paragraph scenarios

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7896 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 5/8/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve file block insertion behavior by replacing empty paragraphs with file blocks and maintaining non-empty paragraph content New Features: - Add logic to replace empty paragraphs with file blocks when inserting Bug Fixes: - Fix issue with unnecessary paragraph creation when inserting file blocks Tests: - Add unit tests for file block insertion in different paragraph scenarios --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:23:02 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8190
No description provided.