[PR #7913] [MERGED] chore: adjust view selector logic #8205

New issue

Closed

opened 2026-03-23 23:23:06 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7913
Author: @richardshiue
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/12/2025
Merged by: @richardshiue

Base: main ← Head: chore/adjust-view-selector-logic

📝 Commits (3)

ecb285a chore: adjust view selector logic
0ab47c2 chore: click on document to expand
399551d chore: code cleanup

📊 Changes

7 files changed (+99 additions, -51 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/ai/service/view_selector_cubit.dart (+21 -8)
📝 frontend/appflowy_flutter/lib/ai/widgets/ai_prompt_modal/ai_prompt_database_selector.dart (+42 -15)
📝 frontend/appflowy_flutter/lib/ai/widgets/prompt_input/select_sources_bottom_sheet.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/ai/widgets/prompt_input/select_sources_menu.dart (+4 -1)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_message_selector_banner.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_message_action_bar.dart (+4 -1)
📝 frontend/appflowy_flutter/macos/Podfile.lock (+22 -22)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Update the view selector logic to improve how views are filtered, hidden, or disabled by basing decisions on ViewSelectorItem and consolidating related logic.

Enhancements:

Refine view selector logic to use ViewSelectorItem instead of ViewPB for ignore type checks and recursive operations.
Centralize and update logic for determining when views should be hidden or disabled in the selector.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7913 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `chore/adjust-view-selector-logic` --- ### 📝 Commits (3) - [`ecb285a`](https://github.com/AppFlowy-IO/AppFlowy/commit/ecb285acfcd2599abb2a820438d9eaae749c661b) chore: adjust view selector logic - [`0ab47c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/0ab47c2c29eabb6681dcd09ac63546fd8eac3dbe) chore: click on document to expand - [`399551d`](https://github.com/AppFlowy-IO/AppFlowy/commit/399551da91b49a3d3512892a9ce70101721235bc) chore: code cleanup ### 📊 Changes **7 files changed** (+99 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/ai/service/view_selector_cubit.dart` (+21 -8) 📝 `frontend/appflowy_flutter/lib/ai/widgets/ai_prompt_modal/ai_prompt_database_selector.dart` (+42 -15) 📝 `frontend/appflowy_flutter/lib/ai/widgets/prompt_input/select_sources_bottom_sheet.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/ai/widgets/prompt_input/select_sources_menu.dart` (+4 -1) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_message_selector_banner.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_message_action_bar.dart` (+4 -1) 📝 `frontend/appflowy_flutter/macos/Podfile.lock` (+22 -22) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ## Summary by Sourcery Update the view selector logic to improve how views are filtered, hidden, or disabled by basing decisions on ViewSelectorItem and consolidating related logic. Enhancements: - Refine view selector logic to use ViewSelectorItem instead of ViewPB for ignore type checks and recursive operations. - Centralize and update logic for determining when views should be hidden or disabled in the selector. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>