[PR #7914] [MERGED] fix: LR issues of desktop search #8206

New issue

Closed

opened 2026-03-23 23:23:06 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7914
Author: @asjqkkkk
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/12/2025
Merged by: @LucasXu0

Base: main ← Head: fix/desktop/seach

📝 Commits (4)

dbd8bdd fix: update error view for search preview
48f0776 chore: add some logs for command palette
1be3782 Merge branch 'main' into fix/desktop/seach
c121497 fix: alignment issue

📊 Changes

6 files changed (+116 additions, -65 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart (+37 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_views_list.dart (+66 -62)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_result_cell.dart (+1 -2)
➕ frontend/resources/flowy_icons/24x/something_wrong_warning.svg (+5 -0)
📝 frontend/resources/translations/en-US.json (+3 -1)

📄 Description

fix: “No matches found” is not suitable for communicating that the view’s metadata cannot be fetched

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Improve error handling and user feedback in the desktop search UI by introducing a dedicated error widget and refining UI behaviors.

Bug Fixes:

Replace misleading 'No matches found' message with a more appropriate error indicator when view metadata cannot be fetched in desktop search.

Enhancements:

Add a new 'SomethingWentWrong' widget to display error states in the search UI.
Improve alignment and scrolling behavior in the recent views list UI.
Add logging for workspace type when toggling the command palette.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7914 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/seach` --- ### 📝 Commits (4) - [`dbd8bdd`](https://github.com/AppFlowy-IO/AppFlowy/commit/dbd8bdd2bc8a7486b4fe2bdef03397a6eea1a4ff) fix: update error view for search preview - [`48f0776`](https://github.com/AppFlowy-IO/AppFlowy/commit/48f0776e86d44fdcbbefdaeeea8531f2d06de9cc) chore: add some logs for command palette - [`1be3782`](https://github.com/AppFlowy-IO/AppFlowy/commit/1be3782d409b0ec0f4a30de4d5ba50c57af71824) Merge branch 'main' into fix/desktop/seach - [`c121497`](https://github.com/AppFlowy-IO/AppFlowy/commit/c121497450f93bd5145c4e31eedac2d7c9f150a0) fix: alignment issue ### 📊 Changes **6 files changed** (+116 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart` (+37 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_views_list.dart` (+66 -62) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_result_cell.dart` (+1 -2) ➕ `frontend/resources/flowy_icons/24x/something_wrong_warning.svg` (+5 -0) 📝 `frontend/resources/translations/en-US.json` (+3 -1) </details> ### 📄 Description - fix: “No matches found” is not suitable for communicating that the view’s metadata cannot be fetched ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Improve error handling and user feedback in the desktop search UI by introducing a dedicated error widget and refining UI behaviors. Bug Fixes: - Replace misleading 'No matches found' message with a more appropriate error indicator when view metadata cannot be fetched in desktop search. Enhancements: - Add a new 'SomethingWentWrong' widget to display error states in the search UI. - Improve alignment and scrolling behavior in the recent views list UI. - Add logging for workspace type when toggling the command palette. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>