[PR #7915] [MERGED] fix: the link name should be a required field #8207

New issue

Closed

opened 2026-03-23 23:23:06 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:23:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7915
Author: @asjqkkkk
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/12/2025
Merged by: @LucasXu0

Base: main ← Head: fix/lr/desktop/link

📝 Commits (1)

84d191f fix: the link name should be a required field

📊 Changes

3 files changed (+90 additions, -3 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_toolbar_test.dart (+83 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_extension.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart (+5 -2)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

Summary by Sourcery

Require the link name field for links, defaulting to the link URL if the name is empty, and add tests to validate link editing and removal scenarios.

Bug Fixes:

Ensure that the link name field is required and defaults to the link URL if left empty when editing or removing links.

Tests:

Add integration tests to verify link insertion, clearing the link name, and link removal behaviors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7915 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/lr/desktop/link` --- ### 📝 Commits (1) - [`84d191f`](https://github.com/AppFlowy-IO/AppFlowy/commit/84d191faa9800644fd45ea19ef6d2cdf7d82eac8) fix: the link name should be a required field ### 📊 Changes **3 files changed** (+90 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_toolbar_test.dart` (+83 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_extension.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart` (+5 -2) </details> ### 📄 Description ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Require the link name field for links, defaulting to the link URL if the name is empty, and add tests to validate link editing and removal scenarios. Bug Fixes: - Ensure that the link name field is required and defaults to the link URL if left empty when editing or removing links. Tests: - Add integration tests to verify link insertion, clearing the link name, and link removal behaviors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>