[PR #7916] [MERGED] fix: using the shortcut to show the search panel will hide the 'Ask AI anything' button #8208

Closed
opened 2026-03-23 23:23:06 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/7916
Author: @asjqkkkk
Created: 5/12/2025
Status: Merged
Merged: 5/13/2025
Merged by: @LucasXu0

Base: mainHead: fix/desktop/search


📝 Commits (8)

  • fdce6ed fix: show search panel by shortcut will hide the 'Ask for AI' button
  • 2272c25 fix: hovering on the search result will hide the border
  • 51d29c8 fix: improve the logic of updating CommandPalette value
  • f23069d Merge branch 'main' into fix/desktop/search
  • 832a7c0 fix: UI issues
  • e5d4938 fix: improve the behavior of search result preview
  • 19a7d0d chore: add integration test for desktop searching
  • af5aa17 feat: enable click search result preview to open the page

📊 Changes

10 files changed (+271 additions, -61 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart (+2 -0)
frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_search_test.dart (+42 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/command_palette/command_palette_test.dart (+77 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_view_ancestors.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart (+13 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart (+26 -14)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_views_list.dart (+30 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_result_cell.dart (+8 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_results_list.dart (+44 -35)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart (+24 -8)

📄 Description

  • Fix: using the shortcut to show the search panel will hide the 'Ask AI anything' button
  • Fix: layout error with search result lists
  • Fix: improve the behavior for displaying "document path" in search results preview

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Fix UI issue where toggling the search panel via shortcut would hide the 'Ask AI anything' button and improve state synchronization between sidebar and command palette.

Bug Fixes:

  • Ensure the 'Ask AI anything' button remains visible when toggling the search panel via shortcut.

Enhancements:

  • Synchronize workspace and space bloc state with the command palette after sidebar initialization.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/7916 **Author:** [@asjqkkkk](https://github.com/asjqkkkk) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/13/2025 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/desktop/search` --- ### 📝 Commits (8) - [`fdce6ed`](https://github.com/AppFlowy-IO/AppFlowy/commit/fdce6edee9a0034ec24a063c49c27628c530569f) fix: show search panel by shortcut will hide the 'Ask for AI' button - [`2272c25`](https://github.com/AppFlowy-IO/AppFlowy/commit/2272c259426255f18036d3cb3f0dac624f6b957d) fix: hovering on the search result will hide the border - [`51d29c8`](https://github.com/AppFlowy-IO/AppFlowy/commit/51d29c865d6a6388b6bf13aef241f84a37b81352) fix: improve the logic of updating CommandPalette value - [`f23069d`](https://github.com/AppFlowy-IO/AppFlowy/commit/f23069d5757448e78c7b4f63785f260c468af028) Merge branch 'main' into fix/desktop/search - [`832a7c0`](https://github.com/AppFlowy-IO/AppFlowy/commit/832a7c0b29716dc051e367135ad902e3504f821d) fix: UI issues - [`e5d4938`](https://github.com/AppFlowy-IO/AppFlowy/commit/e5d49380ecf1ef13477e9586674e702beee6c833) fix: improve the behavior of search result preview - [`19a7d0d`](https://github.com/AppFlowy-IO/AppFlowy/commit/19a7d0d095423027e9ef78cd6f6a4b8a30cd87b1) chore: add integration test for desktop searching - [`af5aa17`](https://github.com/AppFlowy-IO/AppFlowy/commit/af5aa17e29e3c575c97e5825054f3f140695d486) feat: enable click search result preview to open the page ### 📊 Changes **10 files changed** (+271 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart` (+2 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_search_test.dart` (+42 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/command_palette/command_palette_test.dart` (+77 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_view_ancestors.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart` (+13 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/page_preview.dart` (+26 -14) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/recent_views_list.dart` (+30 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_result_cell.dart` (+8 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/command_palette/widgets/search_results_list.dart` (+44 -35) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/desktop_home_screen.dart` (+24 -8) </details> ### 📄 Description - Fix: using the shortcut to show the search panel will hide the 'Ask AI anything' button - Fix: layout error with search result lists - Fix: improve the behavior for displaying "document path" in search results preview ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. ## Summary by Sourcery Fix UI issue where toggling the search panel via shortcut would hide the 'Ask AI anything' button and improve state synchronization between sidebar and command palette. Bug Fixes: - Ensure the 'Ask AI anything' button remains visible when toggling the search panel via shortcut. Enhancements: - Synchronize workspace and space bloc state with the command palette after sidebar initialization. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:23:06 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#8208
No description provided.